Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751850AbbBVGUU (ORCPT ); Sun, 22 Feb 2015 01:20:20 -0500 Received: from mail1.asahi-net.or.jp ([202.224.39.197]:35481 "EHLO mail1.asahi-net.or.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751072AbbBVGUO (ORCPT ); Sun, 22 Feb 2015 01:20:14 -0500 Date: Sun, 22 Feb 2015 15:20:11 +0900 Message-ID: <87y4nq31t0.wl-ysato@users.sourceforge.jp> From: Yoshinori Sato To: Al Viro Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [PATCH v4 03/15] h8300: Exception and Interrupt handling In-Reply-To: <20150221095804.GW29656@ZenIV.linux.org.uk> References: <1424505239-7082-1-git-send-email-ysato@users.sourceforge.jp> <1424505239-7082-4-git-send-email-ysato@users.sourceforge.jp> <20150221095804.GW29656@ZenIV.linux.org.uk> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/24.4 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1004 Lines: 35 At Sat, 21 Feb 2015 09:58:04 +0000, Al Viro wrote: > > On Sat, Feb 21, 2015 at 04:53:47PM +0900, Yoshinori Sato wrote: > > > +resume_userspace: > > + andc #0xbf,ccr > > + mov.l sp,er4 > > + and.w #0xe000,r4 /* er4 <- current thread info */ > > + mov.l @(TI_FLAGS:16,er4),er1 > > + and.l #_TIF_WORK_MASK,er1 > > + beq restore_all:8 > > +work_pending: > > + btst #TIF_NEED_RESCHED,r1l > > + bne work_resched:8 > > + /* work notifysig */ > > + mov.l sp,er0 > > + subs #4,er0 /* er0: pt_regs */ > > + jsr @do_notify_resume > > + bra restore_all:8 > > This is wrong. You really need to handle multiple signals; it ought to > reload er1 and recheck it (or just branch to resume_userspace instead) OK. Fixed. -- Yoshinori Sato -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/