Date: Sun, 22 Feb 2015 09:52:38 +0100 (CET)
From: Jiri Kosina <jkosina@suse.cz>
To: Ingo Molnar <mingo@kernel.org>
cc: Josh Poimboeuf <jpoimboe@redhat.com>, Vojtech Pavlik <vojtech@suse.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Ingo Molnar <mingo@redhat.com>, Seth Jennings <sjenning@redhat.com>,
        linux-kernel@vger.kernel.org,
        Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: live patching design (was: Re: [PATCH 1/3] sched: add
 sched_task_call())
In-Reply-To: <20150221183005.GB8406@gmail.com>
Message-ID: <alpine.LNX.2.00.1502220945370.2357@pobox.suse.cz>
References: <20150219214229.GD15980@treble.redhat.com> <alpine.LNX.2.00.1502200830430.28769@pobox.suse.cz> <alpine.LNX.2.00.1502200939230.28769@pobox.suse.cz> <20150220095003.GA23506@gmail.com> <alpine.LNX.2.00.1502201052050.28769@pobox.suse.cz>
 <20150220104418.GD25076@gmail.com> <alpine.LNX.2.00.1502201151390.28769@pobox.suse.cz> <20150220194901.GB3603@gmail.com> <20150220214613.GA21598@suse.com> <20150220220845.GI15980@treble.redhat.com> <20150221183005.GB8406@gmail.com>
User-Agent: Alpine 2.00 (LNX 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1253
Lines: 33

On Sat, 21 Feb 2015, Ingo Molnar wrote:

> > Plus a lot of processes would see EINTR, causing more havoc.
> 
> Parking threads safely in user mode does not require the propagation of 
> syscall interruption to user-space.

BTW how exactly do you envision this will work? Do I understand your 
proposal correctly that EINTR will be "handled" somewhere in the "live 
patching special signal handler" and then have the interrupted syscall 
restarted?

Even without EINTR propagation to userspace, this would make a lot of new 
syscall restarts that were not there before, and I am still to be 
convinced that this is something we are not going to cause a lot of new 
user-visible breakage with.

Yes, the breakage would be caused kernel bugs (I mostly envision drivers 
to be problematic in this area) that would be nice to have fixed, but the 
user experience that will come out of it will be just completely horrible.

Or did I misunderstand what you are really proposing?

Thanks,

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/