Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751810AbbBVKbD (ORCPT ); Sun, 22 Feb 2015 05:31:03 -0500 Received: from mail-ie0-f180.google.com ([209.85.223.180]:33779 "EHLO mail-ie0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751297AbbBVKa6 (ORCPT ); Sun, 22 Feb 2015 05:30:58 -0500 MIME-Version: 1.0 X-Originating-IP: [212.51.149.109] In-Reply-To: <20150218190347.GA12689@ikki.ethgen.ch> References: <1424276692.27236.1.camel@intel.com> <87mw4bw7o7.fsf@intel.com> <20150218190347.GA12689@ikki.ethgen.ch> Date: Sun, 22 Feb 2015 11:30:58 +0100 X-Google-Sender-Auth: IiJZ-J5_B4qyfyP2yRcnF6qSTnA Message-ID: Subject: Re: [KERNEL] Re: [KERNEL] Regression bug in drm/i915, Wrong assumption in commit e11aa36 breaks suspend on at least lenovo x61 From: Daniel Vetter To: Klaus Ethgen Cc: Jani Nikula , Imre Deak , "intel-gfx@lists.freedesktop.org" , Linux Kernel Mailing List , dri-devel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1670 Lines: 36 On Wed, Feb 18, 2015 at 8:03 PM, Klaus Ethgen wrote: > Am Mi den 18. Feb 2015 um 16:39 schrieb Jani Nikula: >> On Tue, 17 Feb 2015, Klaus Ethgen wrote: >> > After solving the conflicts, I applied the revert (see attachment) to >> > v3.18.7. I think it should also apply to the current head. With that >> > patch, suspend is working again on that version. >> > >> > However, I have not to deep knowledge of that subsystem, so please, >> > someone who have, have a deeper look into it. I especially do not know >> > if the lines in .../intel_pm.c are correct or better leaving them as >> > they are in v3.18.7. >> > >> > I want to have it working on a version that I know is stable before >> > asking to pull it to head. >> >> Hi Klaus, we fear this patch may hide the actual cause. > > That might be. But that might be a second step, to find the actual > cause. I think first the patch that causes the problem should be > fixed/reverted to have a working kernel and the next step would be to > find the real cause. I think the rever also breaks soix on newer platforms. Instead I think intel_runtime_pm_disable_interrupts needs to grow a synchronize_irq() after having disabled all the interrupt sources. But that's just drive-by debugging, I might be off the charts ;-) -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/