Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751982AbbBVKeM (ORCPT ); Sun, 22 Feb 2015 05:34:12 -0500 Received: from mail-ig0-f170.google.com ([209.85.213.170]:64707 "EHLO mail-ig0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751387AbbBVKeK (ORCPT ); Sun, 22 Feb 2015 05:34:10 -0500 MIME-Version: 1.0 X-Originating-IP: [212.51.149.109] In-Reply-To: <1424443346-9935-2-git-send-email-gbeeresh@codeaurora.org> References: <1424443346-9935-1-git-send-email-gbeeresh@codeaurora.org> <1424443346-9935-2-git-send-email-gbeeresh@codeaurora.org> Date: Sun, 22 Feb 2015 11:34:09 +0100 X-Google-Sender-Auth: -noLY7DXLxkaeVli1n60EzCaY3c Message-ID: Subject: Re: [PATCH 2/2] drm/msm: Support NV12MT format in mdp4 From: Daniel Vetter To: Beeresh Gopal Cc: dri-devel , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1231 Lines: 32 On Fri, Feb 20, 2015 at 3:42 PM, Beeresh Gopal wrote: > +/* Samsung framebuffer modifiers */ > + > +/* > + * NV12 64x32 Tiled > + * > + * 2 planes Y and CbCr, grouped into 64x32 macro tiles, > + * with a non-standard order in memory (Z-shape). > + * > + * Pixel layout identical to DRM_FORMAT_NV21 format: > + * index 0 = Y plane, [7:0] Y > + * index 1 = Cb:Cr plane, [15:0] Cb:Cr little endian > + */ > +#define DRM_FORMAT_MOD_SAMSUNG_64_32_TILE fourcc_mod_code(SAMSUNG, 1) This description mixes layout information with pixel format. Strictly speaking you could use this for other formats, but since the description doesn't mention whether this is in bytes or pixels that's a bit awkward. Or just mandatae that this can only be used with NV12 fourcc (and maybe add a check for that into the core drm code. Also, is this really samsung and not mpeg? -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/