Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752028AbbBVLH2 (ORCPT ); Sun, 22 Feb 2015 06:07:28 -0500 Received: from mail.skyhub.de ([78.46.96.112]:45883 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751744AbbBVLH0 (ORCPT ); Sun, 22 Feb 2015 06:07:26 -0500 Date: Sun, 22 Feb 2015 12:06:29 +0100 From: Borislav Petkov To: "Maciej W. Rozycki" Cc: Andy Lutomirski , Ingo Molnar , Oleg Nesterov , Rik van Riel , X86 ML , "linux-kernel@vger.kernel.org" , Linus Torvalds Subject: Re: [RFC PATCH] x86, fpu: Use eagerfpu by default on all CPUs Message-ID: <20150222110629.GB7529@pd.tnic> References: <20150221093150.GA27841@gmail.com> <20150221163840.GA32073@pd.tnic> <20150221172914.GB32073@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1502 Lines: 35 On Sat, Feb 21, 2015 at 06:18:01PM -0800, Andy Lutomirski wrote: > That's true. The question is whether there are enough of them, and > whether twiddling TS is fast enough, that it's worth it. Yes, and let me make it clear what I'm trying to do here: I want to make sure that eager FPU handling (both allocation and switching - and no, I'm not confusing the concepts) *doesn't* *hurt* any relevant workload. If it does, then we'll stop wasting time right there. But(!), if the CR0.TS lazy dance turns out to be really slow and the eager handling doesn't bring a noticeable slowdown, in comparison, we should consider doing the eager thing by default. After running a lot more benchmarks, of course. Which brings me to the main reason why we're doing this: code simplification. If we switch to eager, we'll kill a lot of non-trivial code and the FPU handling in the kernel becomes dumb and nice again. > > And last but not least, why does the handling of CR0.TS traps have to be > > complicated? It does not look like rocket science to me, it should be a If you think so, just go and look at the latest tip/x86/fpu commits and the amount of WTF in the commit messages. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/