Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752317AbbBVNOa (ORCPT ); Sun, 22 Feb 2015 08:14:30 -0500 Received: from mail-ob0-f177.google.com ([209.85.214.177]:33920 "EHLO mail-ob0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752145AbbBVNO3 (ORCPT ); Sun, 22 Feb 2015 08:14:29 -0500 MIME-Version: 1.0 X-Originating-IP: [76.119.162.148] In-Reply-To: <1424530825.6539.7.camel@stgolabs.net> References: <1424304641-28965-1-git-send-email-dbueso@suse.de> <1424304641-28965-2-git-send-email-dbueso@suse.de> <1424481838.6539.2.camel@stgolabs.net> <1424530825.6539.7.camel@stgolabs.net> Date: Sun, 22 Feb 2015 08:14:28 -0500 Message-ID: Subject: Re: [PATCH 1/3] kernel/audit: consolidate handling of mm->exe_file From: Paul Moore To: Davidlohr Bueso Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Eric Paris , linux-audit@redhat.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1265 Lines: 30 On Sat, Feb 21, 2015 at 10:00 AM, Davidlohr Bueso wrote: > On Sat, 2015-02-21 at 08:45 -0500, Paul Moore wrote: >> On Fri, Feb 20, 2015 at 8:23 PM, Davidlohr Bueso wrote: >> > On Wed, 2015-02-18 at 22:23 -0500, Paul Moore wrote: >> >> I'd prefer if the audit_log_d_path_exe() helper wasn't a static inline. >> > >> > What do you have in mind? >> >> Pretty much what I said before, audit_log_d_path_exe() as a >> traditional function and not an inline. Put the function in >> kernel/audit.c. > > well yes I know that, which is why I showed you the code sizes. Now > again, do you have any reason? This function will only get less bulky in > the future. The code size was pretty negligible from my point of view, not enough to outweigh my preference for a non-inlined version of the function. Also, I expect this function will be one of the things that gets shuffled/reworked in the coming months as we make some architectural changes to audit. -- paul moore www.paul-moore.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/