Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752301AbbBVPA1 (ORCPT ); Sun, 22 Feb 2015 10:00:27 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:58715 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752212AbbBVPAX (ORCPT ); Sun, 22 Feb 2015 10:00:23 -0500 Message-ID: In-Reply-To: References: <1423576735-26267-1-git-send-email-gbroner@codeaurora.org> <1423576735-26267-3-git-send-email-gbroner@codeaurora.org> Date: Sun, 22 Feb 2015 15:00:21 -0000 Subject: Re: [PATCH v2 2/4] scsi: ufs: add debugfs for ufs From: "Gilad Broner" To: "Akinobu Mita" Cc: "Gilad Broner" , "Jej B" , "LKML" , "linux-scsi@vger.kernel.org" , linux-arm-msm@vger.kernel.org, "Santosh Y" , linux-scsi-owner@vger.kernel.org, "Subhash Jadavani" , "Yaniv Gardi" , "Dolev Raviv" , "Lee Susman" , "Raviv Shvili" , "Vinayak Holikatti" , "James E.J. Bottomley" User-Agent: SquirrelMail/1.4.22-4.el6 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Priority: 3 (Normal) Importance: Normal Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1136 Lines: 37 > UFSDBG_REMOVE_DEBUGFS() is not called in the driver unloading path. > So ufs debugfs directory is not removed when unloading driver. It > should be called in ufshcd_remove(). > > BTW, do we really need UFSDBG_ADD_DEBUGFS() and UFSDBG_REMOVE_DEBUGFS() > macros? > We can use static inline functions in ufs-debugfs.h when !CONFIG_DEBUG_FS. > > #ifdef CONFIG_DEBUG_FS > void ufsdbg_add_debugfs(struct ufs_hba *hba); > > void ufsdbg_remove_debugfs(struct ufs_hba *hba); > #else > static inline void ufsdbg_add_debugfs(struct ufs_hba *hba) > { > } > > static inline void ufsdbg_remove_debugfs(struct ufs_hba *hba) > { > } > #endif > Thanks, I will fix the above two points and upload another patch. Gilad. -- Qualcomm Israel, on behalf of Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/