Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752223AbbBVVEu (ORCPT ); Sun, 22 Feb 2015 16:04:50 -0500 Received: from mail-ig0-f177.google.com ([209.85.213.177]:55129 "EHLO mail-ig0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752111AbbBVVEt (ORCPT ); Sun, 22 Feb 2015 16:04:49 -0500 MIME-Version: 1.0 X-Originating-IP: [2601:6:6b00:f9::a66] In-Reply-To: <20150206025915.GA31650@us.ibm.com> References: <20150206025915.GA31650@us.ibm.com> Date: Sun, 22 Feb 2015 16:04:48 -0500 Message-ID: Subject: Re: [RFC][PATCH] perf: Implement read_group() PMU operation From: Cody P Schafer To: Sukadev Bhattiprolu Cc: Peter Zijlstra , Ingo Molnar , Michael Ellerman , Anton Blanchard , Stephane Eranian , Jiri Olsa , Arnaldo Carvalho de Melo , LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1216 Lines: 27 On Thu, Feb 5, 2015 at 9:59 PM, Sukadev Bhattiprolu wrote: > From: Sukadev Bhattiprolu > Date: Thu Feb 5 20:56:20 EST 2015 -0300 > Subject: [RFC][PATCH] perf: Implement read_group() PMU operation > > This is a lightly tested, exploratory patch to allow PMUs to return > several counters at once. Appreciate any comments :-) > Back when I was fiddling with this, I started looking into changing the {start,commit,cancel}_txn to operate on (struct perf_event *) rather than (struct pmu *), and commit_txn would generate the actual request & reads based on the perf_event's group (sounds similar but not identical to what Peter's proposed previously). The key bit I was concerned about was that these "PMUs" aren't actually physical hw, so it made a bit more sense to pin the grouping to a group rather than a txn over a PMU. [Of course, I never did confirm if that actually fit with how perf was modeling txns] -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/