Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752246AbbBWDlN (ORCPT ); Sun, 22 Feb 2015 22:41:13 -0500 Received: from e23smtp04.au.ibm.com ([202.81.31.146]:51918 "EHLO e23smtp04.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751573AbbBWDlM (ORCPT ); Sun, 22 Feb 2015 22:41:12 -0500 Content-Type: text/plain; charset=UTF-8 From: Ian Munsie To: Rasmus Villemoes Cc: Michael Neuling , linuxppc-dev , linux-kernel Subject: Re: [PATCH] cxl: Remove useless precision specifiers In-reply-to: <1424438782-31545-1-git-send-email-linux@rasmusvillemoes.dk> References: <1424438782-31545-1-git-send-email-linux@rasmusvillemoes.dk> Date: Mon, 23 Feb 2015 14:40:08 +1100 Message-Id: <1424662685-sup-6648@delenn.ozlabs.ibm.com> User-Agent: Sup/0.20.0 Content-Transfer-Encoding: 8bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15022303-0013-0000-0000-000000D7E4DB Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 886 Lines: 20 Excerpts from Rasmus Villemoes's message of 2015-02-21 00:26:22 +1100: > C99 says that a precision given as simply '.' with no following digits > or * should be interpreted as 0. The kernel's printf implementation, > however, treats this case as if the precision was omitted. C99 also > says that if both the precision and value are 0, no digits should be > printed. Even if the kernel followed C99 to the letter, I don't think > that would be particularly useful in these cases, so just remove the > precision specifiers. Nice catch Rasmus, but I think a better patch would be one that adds the missing precision (%.16llx). Cheers, -Ian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/