Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751642AbbBWGGh (ORCPT ); Mon, 23 Feb 2015 01:06:37 -0500 Received: from mail7.hitachi.co.jp ([133.145.228.42]:37662 "EHLO mail7.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750997AbbBWGGf (ORCPT ); Mon, 23 Feb 2015 01:06:35 -0500 Message-ID: <54EAC365.6010508@hitachi.com> Date: Mon, 23 Feb 2015 15:06:29 +0900 From: Masami Hiramatsu Organization: Hitachi, Ltd., Japan User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Namhyung Kim Cc: Arnaldo Carvalho de Melo , Peter Zijlstra , Adrian Hunter , linux-kernel@vger.kernel.org, Ingo Molnar , Paul Mackerras , Jiri Olsa , Borislav Petkov , Hemant Kumar Subject: Re: [perf/core PATCH v4 2/2] perf buildid-cache: Add --purge FILE to remove all caches of FILE References: <20150220094145.4942.22046.stgit@localhost.localdomain> <20150220094150.4942.13002.stgit@localhost.localdomain> <20150221135645.GA10557@danjae> In-Reply-To: <20150221135645.GA10557@danjae> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2697 Lines: 100 (2015/02/21 22:56), Namhyung Kim wrote: > Hi Masami, > > On Fri, Feb 20, 2015 at 06:41:50PM +0900, Masami Hiramatsu wrote: >> Add --purge FILE to remove all caches of FILE. >> Since the current --remove FILE removes a cache which has >> same build-id of given FILE. Since the command takes a >> FILE path, it can confuse user who tries to remove cache >> about FILE path. >> >> ----- >> # ./perf buildid-cache -v --add ./perf >> Adding 133b7b5486d987a5ab5c3ebf4ea14941f45d4d4f ./perf: Ok >> # (update the ./perf binary) >> # ./perf buildid-cache -v --remove ./perf >> Removing 305bbd1be68f66eca7e2d78db294653031edfa79 ./perf: FAIL >> ./perf wasn't in the cache >> ----- >> Actually, the --remove's FAIL is not shown, it just silently fails. >> >> So, this patch adds --purge FILE action for such usecase. >> perf buildid-cache --purge FILE removes all caches which >> has same FILE path. >> In other words, it removes all caches including old binaries. >> >> ----- >> # ./perf buildid-cache -v --add ./perf >> Adding 133b7b5486d987a5ab5c3ebf4ea14941f45d4d4f ./perf: Ok >> # (update the ./perf binary) >> # ./perf buildid-cache -v --purge ./perf >> Removing 133b7b5486d987a5ab5c3ebf4ea14941f45d4d4f ./perf: Ok >> ----- >> >> BTW, if you want to purge all the caches, remove ~/.debug/* . >> >> Signed-off-by: Masami Hiramatsu > > I have a nitpick below - other than that both patches look good. > > Acked-by: Namhyung Kim Thanks! > > Thanks, > Namhyung > [...] >> +static int build_id_cache__purge_path(const char *pathname) >> +{ >> + struct strlist *list; >> + struct str_node *pos; >> + int err; >> + >> + list = build_id_cache__list_build_ids(pathname); >> + if (!list) >> + return 0; >> + >> + strlist__for_each(pos, list) { >> + err = build_id_cache__remove_s(pos->s); >> + if (verbose) >> + pr_info("Removing %s %s: %s\n", pos->s, pathname, >> + err ? "FAIL" : "Ok"); > > You can simply use pr_debug() here. :) Yes, but other operations already uses pr_info instead of pr_debug. I thinks we'd better change them all at once. Thank you, > > Thanks, > Namhyung > > >> + if (err) >> + break; >> + } >> + strlist__delete(list); >> + >> + return err; >> +} >> + > -- Masami HIRAMATSU Software Platform Research Dept. Linux Technology Research Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/