Message-ID: <1424673731.20944.24.camel@perches.com>
Subject: Re: [PATCH] cxl: Remove useless precision specifiers
From: Joe Perches <joe@perches.com>
To: Ian Munsie <imunsie@au1.ibm.com>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Michael Neuling <mikey@neuling.org>,
        linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Date: Sun, 22 Feb 2015 22:42:11 -0800
In-Reply-To: <1424662685-sup-6648@delenn.ozlabs.ibm.com>
References: <1424438782-31545-1-git-send-email-linux@rasmusvillemoes.dk>
	 <1424662685-sup-6648@delenn.ozlabs.ibm.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1095
Lines: 26

On Mon, 2015-02-23 at 14:40 +1100, Ian Munsie wrote:
> Excerpts from Rasmus Villemoes's message of 2015-02-21 00:26:22 +1100:
> > C99 says that a precision given as simply '.' with no following digits
> > or * should be interpreted as 0. The kernel's printf implementation,
> > however, treats this case as if the precision was omitted. C99 also
> > says that if both the precision and value are 0, no digits should be
> > printed. Even if the kernel followed C99 to the letter, I don't think
> > that would be particularly useful in these cases, so just remove the
> > precision specifiers.
> 
> Nice catch Rasmus, but I think a better patch would be one that adds the
> missing precision (%.16llx).

The kernel much more commonly uses %016llx

$ git grep "%016llx" | grep -v staging | wc -l
792
$ git grep "%\.16llx" | grep -v staging | wc -l
36


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/