Message-id: <54EAFC64.1050209@samsung.com>
Date: Mon, 23 Feb 2015 11:09:40 +0100
From: Andrzej Hajda <a.hajda@samsung.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101
 Thunderbird/31.4.0
MIME-version: 1.0
Newsgroups: gmane.linux.kernel,gmane.comp.video.dri.devel,gmane.linux.ports.arm.kernel
To: Sylvain Rochet <sylvain.rochet@finsecur.com>,
        Boris Brezillon <boris.brezillon@free-electrons.com>,
        David Airlie <airlied@linux.ie>, dri-devel@lists.freedesktop.org,
        Nicolas Ferre <nicolas.ferre@atmel.com>,
        Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
        Alexandre Belloni <alexandre.belloni@free-electrons.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Daniel Vetter <daniel@ffwll.ch>, Kevin Hilman <khilman@kernel.org>,
        Wenyou Yang <wenyou.yang@atmel.com>
Subject: Re: [PATCHv3 1/2] drm: atmel-hlcdc: Add PM suspend/resume support
References: <1424627464-16869-1-git-send-email-sylvain.rochet@finsecur.com>
 <1424627464-16869-2-git-send-email-sylvain.rochet@finsecur.com>
In-reply-to: <1424627464-16869-2-git-send-email-sylvain.rochet@finsecur.com>
Content-type: text/plain; charset=windows-1252
Content-transfer-encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2780
Lines: 89

On 02/22/2015 06:51 PM, Sylvain Rochet wrote:
> On suspend: switch off CRTC if not already suspended with runtime PM
> 
> On resume: switch on CRTC if we were not already suspended from runtime
> PM while suspending.
> 
> Signed-off-by: Sylvain Rochet <sylvain.rochet@finsecur.com>

Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>

Regards
Andrzej

> ---
>  drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 47 ++++++++++++++++++++++++++++
>  1 file changed, 47 insertions(+)
> 
> diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
> index 22c3cca..c4bb1f9 100644
> --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
> +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
> @@ -559,6 +559,52 @@ static int atmel_hlcdc_dc_drm_remove(struct platform_device *pdev)
>  	return 0;
>  }
>  
> +#ifdef CONFIG_PM
> +static int atmel_hlcdc_dc_drm_suspend(struct device *dev)
> +{
> +	struct drm_device *drm_dev = dev_get_drvdata(dev);
> +	struct drm_crtc *crtc;
> +
> +	if (pm_runtime_suspended(dev))
> +		return 0;
> +
> +	drm_modeset_lock_all(drm_dev);
> +	list_for_each_entry(crtc, &drm_dev->mode_config.crtc_list, head) {
> +		struct drm_crtc_helper_funcs *crtc_funcs = crtc->helper_private;
> +		if (crtc->enabled) {
> +			crtc_funcs->disable(crtc);
> +			/* save enable state for resume */
> +			crtc->enabled = true;
> +		}
> +	}
> +	drm_modeset_unlock_all(drm_dev);
> +	return 0;
> +}
> +
> +static int atmel_hlcdc_dc_drm_resume(struct device *dev)
> +{
> +	struct drm_device *drm_dev = dev_get_drvdata(dev);
> +	struct drm_crtc *crtc;
> +
> +	if (pm_runtime_suspended(dev))
> +		return 0;
> +
> +	drm_modeset_lock_all(drm_dev);
> +	list_for_each_entry(crtc, &drm_dev->mode_config.crtc_list, head) {
> +		struct drm_crtc_helper_funcs *crtc_funcs = crtc->helper_private;
> +		if (crtc->enabled) {
> +			crtc->enabled = false;
> +			crtc_funcs->enable(crtc);
> +		}
> +	}
> +	drm_modeset_unlock_all(drm_dev);
> +	return 0;
> +}
> +#endif
> +
> +static SIMPLE_DEV_PM_OPS(atmel_hlcdc_dc_drm_pm_ops,
> +		atmel_hlcdc_dc_drm_suspend, atmel_hlcdc_dc_drm_resume);
> +
>  static const struct of_device_id atmel_hlcdc_dc_of_match[] = {
>  	{ .compatible = "atmel,hlcdc-display-controller" },
>  	{ },
> @@ -569,6 +615,7 @@ static struct platform_driver atmel_hlcdc_dc_platform_driver = {
>  	.remove	= atmel_hlcdc_dc_drm_remove,
>  	.driver	= {
>  		.name	= "atmel-hlcdc-display-controller",
> +		.pm	= &atmel_hlcdc_dc_drm_pm_ops,
>  		.of_match_table = atmel_hlcdc_dc_of_match,
>  	},
>  };
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/