Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752495AbbBWKXU (ORCPT ); Mon, 23 Feb 2015 05:23:20 -0500 Received: from mail-oi0-f51.google.com ([209.85.218.51]:43446 "EHLO mail-oi0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752396AbbBWKXS (ORCPT ); Mon, 23 Feb 2015 05:23:18 -0500 Message-ID: <54EAFF92.5070709@monstr.eu> Date: Mon, 23 Feb 2015 11:23:14 +0100 From: Michal Simek Reply-To: monstr@monstr.eu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Andrew Morton CC: linux-kernel@vger.kernel.org Subject: Re: [PATCH] kconfig: Use macros which are already defined References: In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="WsbIhFx6SQuNcX7qfGQfbgP0nWW7IspbN" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2098 Lines: 70 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --WsbIhFx6SQuNcX7qfGQfbgP0nWW7IspbN Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Hi Andrew, On 12/11/2014 10:00 AM, Michal Simek wrote: > It is better to use macros which are already available > because then there is just one location which needs to be change. >=20 > Signed-off-by: Michal Simek > --- >=20 > FYI: Fengguang's testing system doesn't show any build error. > --- > include/linux/kconfig.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/include/linux/kconfig.h b/include/linux/kconfig.h > index be342b94c640..71acdf650e2e 100644 > --- a/include/linux/kconfig.h > +++ b/include/linux/kconfig.h > @@ -28,7 +28,7 @@ > * > */ > #define IS_ENABLED(option) \ > - (config_enabled(option) || config_enabled(option##_MODULE)) > + (IS_BUILTIN(option) || IS_MODULE(option)) >=20 > /* > * IS_BUILTIN(CONFIG_FOO) evaluates to 1 if CONFIG_FOO is set to 'y', = 0 > -- > 1.8.2.3 >=20 Can you please add this to your queue? Thanks, Michal --=20 Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform --WsbIhFx6SQuNcX7qfGQfbgP0nWW7IspbN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEARECAAYFAlTq/5IACgkQykllyylKDCHT4ACgljoOXK1ocUEKOJVIs0OZnVZ+ Yt4An3YDcK9r83+7jiKwDvB2qkkqD39+ =AWu2 -----END PGP SIGNATURE----- --WsbIhFx6SQuNcX7qfGQfbgP0nWW7IspbN-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/