Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752553AbbBWKZ2 (ORCPT ); Mon, 23 Feb 2015 05:25:28 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:37676 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751886AbbBWKZX (ORCPT ); Mon, 23 Feb 2015 05:25:23 -0500 Message-Id: <1424687122.3034736.231116061.6D0FF46D@webmail.messagingengine.com> X-Sasl-Enc: esvA7+Zt5bMoHW+6jyB6cx0ruvHUiB6b8gr/KuZxZaiZ 1424687122 From: Henrique de Moraes Holschuh To: Bastien Nocera , Darren Hart , ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Jiri Kosina MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain X-Mailer: MessagingEngine.com Webmail Interface - ajax-4ba7306c In-Reply-To: <1424443481.22910.19.camel@hadess.net> References: <1424443481.22910.19.camel@hadess.net> Subject: Re: [PATCH 7/7] thinkpad_acpi: use DEVICE_ATTR_* macros Date: Mon, 23 Feb 2015 07:25:22 -0300 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 807 Lines: 21 On Fri, Feb 20, 2015, at 11:44, Bastien Nocera wrote: > Use the DEVICE_ATTR_RW macro to reduce boiler plate So far, so good, but you also used the DEVICE_ATTR_RO macro... > and move the attribute declaration to get rid of function signatures. I didn't see any "move the attribute declaration" done in this patch. Other than that, looks good. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/