Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752751AbbBWK3L (ORCPT ); Mon, 23 Feb 2015 05:29:11 -0500 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:56602 "EHLO relay6-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752477AbbBWK3J (ORCPT ); Mon, 23 Feb 2015 05:29:09 -0500 X-Originating-IP: 83.155.44.161 Message-ID: <1424687254.28361.11.camel@hadess.net> Subject: Re: [PATCH 7/7] thinkpad_acpi: use DEVICE_ATTR_* macros From: Bastien Nocera To: Henrique de Moraes Holschuh Cc: Darren Hart , ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Jiri Kosina Date: Mon, 23 Feb 2015 11:27:34 +0100 In-Reply-To: <1424687122.3034736.231116061.6D0FF46D@webmail.messagingengine.com> References: <1424443481.22910.19.camel@hadess.net> <1424687122.3034736.231116061.6D0FF46D@webmail.messagingengine.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.10 (3.12.10-1.fc21) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 788 Lines: 22 On Mon, 2015-02-23 at 07:25 -0300, Henrique de Moraes Holschuh wrote: > On Fri, Feb 20, 2015, at 11:44, Bastien Nocera wrote: > > Use the DEVICE_ATTR_RW macro to reduce boiler plate > > So far, so good, but you also used the DEVICE_ATTR_RO macro... > > > and move the attribute declaration to get rid of function signatures. > > I didn't see any "move the attribute declaration" done in this patch. Too much cut'n'paste from another similar patch. I'll resend with a better commit message. > Other than that, looks good. Great, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/