Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752344AbbBWLZx (ORCPT ); Mon, 23 Feb 2015 06:25:53 -0500 Received: from mga03.intel.com ([134.134.136.65]:11483 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752281AbbBWLZw (ORCPT ); Mon, 23 Feb 2015 06:25:52 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,630,1418112000"; d="scan'208";a="531381624" Date: Mon, 23 Feb 2015 16:53:01 +0530 From: Vinod Koul To: Qiao Zhou Cc: zhangfei.gao@linaro.org, dan.j.williams@intel.com, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dma: mmp-tdma: refine dma disable and dma-pos update Message-ID: <20150223112301.GB5208@intel.com> References: <1423140859-20074-1-git-send-email-zhouqiao@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1423140859-20074-1-git-send-email-zhouqiao@marvell.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 941 Lines: 20 On Thu, Feb 05, 2015 at 08:54:19PM +0800, Qiao Zhou wrote: > Below are the refinements. > 1. Set DMA abort bit when disabling dma channel. This will clear > the remaining data in dma FIFO, to fix channel-swap issue. > 2. Read DMA HW pointer when updating DMA status. Previously dma > position is calculated by adding one period size in dma interrupt. > This is inaccurate/insufficient for some high-quality audio APP. > Since interrupt bottom half handler has variable schedule delay, > it causes big error when calculating sample delay. Read the actual > HW pointer and feedback can improve the accuracy. > 3. Do some minor code clean. This fails to apply for me, care to rebase pls -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/