Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752422AbbBWL0W (ORCPT ); Mon, 23 Feb 2015 06:26:22 -0500 Received: from mga02.intel.com ([134.134.136.20]:63415 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752350AbbBWL0U (ORCPT ); Mon, 23 Feb 2015 06:26:20 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,630,1418112000"; d="scan'208";a="681937537" Date: Mon, 23 Feb 2015 16:53:30 +0530 From: Vinod Koul To: Qiao Zhou Cc: dan.j.williams@intel.com, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, zhangfei.gao@linaro.org Subject: Re: [PATCH] dma: mmp-pdma: fix irq handler overwrite physical chan issue Message-ID: <20150223112330.GC5208@intel.com> References: <1423030563-2090-1-git-send-email-zhouqiao@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1423030563-2090-1-git-send-email-zhouqiao@marvell.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 970 Lines: 24 On Wed, Feb 04, 2015 at 02:16:03PM +0800, Qiao Zhou wrote: > Some dma channels may be reserved for other purpose in other layer, > like secure driver in EL2/EL3. PDMA driver can see the interrupt > status, but it should not try to handle related interrupt, since it > doesn't belong to PDMA driver in kernel. These interrupts should be > handled by corresponding client/module.Otherwise, it will overwrite > illegal memory and cause unexpected issues, since pdma driver only > requests resources for pdma channels. > > In PDMA driver, the reserved channels are at the end of total 32 > channels. If we find interrupt bit index is not smaller than total > dma channels, we should ignore it. Applied, now Thanks -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/