Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752986AbbBWMCq (ORCPT ); Mon, 23 Feb 2015 07:02:46 -0500 Received: from cantor2.suse.de ([195.135.220.15]:46612 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752828AbbBWMCo (ORCPT ); Mon, 23 Feb 2015 07:02:44 -0500 Date: Mon, 23 Feb 2015 13:02:41 +0100 (CET) From: Jiri Kosina To: David Herrmann cc: Pavel Machek , kernel list , "open list:HID CORE LAYER" , rydberg@bitmath.org, Frank Praznik Subject: Re: 3.19: Sony playstation controller causes kernel oops In-Reply-To: Message-ID: References: <20150222213513.GA15224@amd> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1623 Lines: 52 On Mon, 23 Feb 2015, David Herrmann wrote: > Hi Jiri > > On Sun, Feb 22, 2015 at 10:50 PM, Jiri Kosina wrote: > > [ some CCs added and full dmesg kept for reference ] > > > > On Sun, 22 Feb 2015, Pavel Machek wrote: > > > >> Hi! > >> > >> I plugged in part of PS move to the PC, to let it charge. Got: full > >> dmesg in attachment. I believe I charged it in PC before, but it may > >> be year ago or more. > >> > >> Ideas? > > > > Ok, this is embarassing. I guess the patch below fixes it, right? (the > > spinlock got introduced in d2d782fccee, so I guess you didn't have it a > > year ago) > > > > diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c > > index 31e9d25..3756a62 100644 > > --- a/drivers/hid/hid-sony.c > > +++ b/drivers/hid/hid-sony.c > > @@ -2140,6 +2140,7 @@ static int __init sony_init(void) > > { > > dbg_hid("Sony:%s\n", __func__); > > > > + spin_lock_init(&sony_dev_list_lock); > > return hid_register_driver(&sony_driver); > > } > > Nice catch. I'd prefer the patch below, though. For both: > Reviewed-by: David Herrmann Thanks. I already used the DEFINE_SPINLOCK() variant and pushed it our earlier today. There was also missing sc->lock initialization in per-device probe, Frank sent patch for that as well. Both now applied and pushed out. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/