Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752861AbbBWM5Q (ORCPT ); Mon, 23 Feb 2015 07:57:16 -0500 Received: from ns.mm-sol.com ([37.157.136.199]:54790 "EHLO extserv.mm-sol.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752028AbbBWM5M (ORCPT ); Mon, 23 Feb 2015 07:57:12 -0500 Message-ID: <1424696228.2340.7.camel@mm-sol.com> Subject: Re: [PATCH] spmi: pmic_arb: enable build on arm64 platforms From: "Ivan T. Ivanov" To: Paul Bolle Cc: Stanimir Varbanov , Greg Kroah-Hartman , Kumar Gala , Stephen Boyd , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Date: Mon, 23 Feb 2015 14:57:08 +0200 In-Reply-To: <1423075571.27378.2.camel@x220> References: <1422971459-20431-1-git-send-email-svarbanov@mm-sol.com> <1422996157.23894.35.camel@x220> <54D23527.2080509@mm-sol.com> <1423062897.23022.19.camel@x220> <54D23A47.8040908@mm-sol.com> <1423075571.27378.2.camel@x220> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.13.7-fta1.2~trusty Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1742 Lines: 44 On Wed, 2015-02-04 at 19:46 +0100, Paul Bolle wrote: > On Wed, 2015-02-04 at 17:27 +0200, Stanimir Varbanov wrote: > > On 02/04/2015 05:14 PM, Paul Bolle wrote: > > > On Wed, 2015-02-04 at 17:05 +0200, Stanimir Varbanov wrote: > > > > On 02/03/2015 10:42 PM, Paul Bolle wrote: > > > > > On Tue, 2015-02-03 at 15:50 +0200, Stanimir Varbanov wrote: > > > > > > diff --git a/drivers/spmi/Kconfig b/drivers/spmi/Kconfig > > > > > > index bf1295e..115348c 100644 > > > > > > --- a/drivers/spmi/Kconfig > > > > > > +++ b/drivers/spmi/Kconfig > > > > > > @@ -12,7 +12,7 @@ if SPMI > > > > > > > > > > > > config SPMI_MSM_PMIC_ARB > > > > > > tristate "Qualcomm MSM SPMI Controller (PMIC Arbiter)" > > > > > > - depends on ARM > > > > > > + depends on ARM || ARM64 > > > > > > depends on IRQ_DOMAIN > > > > > > depends on ARCH_QCOM || COMPILE_TEST > > > > > > default ARCH_QCOM > > > > > > > > > > But only if COMPILE_TEST is set too, isn't it? Is that intended? > > > > > > > > No, the driver will be used on arm64 qcom platforms, also. > > > > > > But ARCH_QCOM currently is (32 bit) arch/arm only, isn't it? > > > > Currently yes, but we want to be prepared to support PMIC's which will > > be used on arm64 platforms, although they are not upstream yet. > > Please make the commit summary reflect that, as in: > "spmi: pmic_arb: enable test build on arm64" > > Commit explanation likewise. What if we just drop ARM dependency? Regards, Ivan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/