Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752248AbbBWNdj (ORCPT ); Mon, 23 Feb 2015 08:33:39 -0500 Received: from mail-ie0-f174.google.com ([209.85.223.174]:35401 "EHLO mail-ie0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751898AbbBWNdh (ORCPT ); Mon, 23 Feb 2015 08:33:37 -0500 MIME-Version: 1.0 In-Reply-To: <1424687361-17787-1-git-send-email-architt@codeaurora.org> References: <1424687361-17787-1-git-send-email-architt@codeaurora.org> Date: Mon, 23 Feb 2015 08:33:36 -0500 Message-ID: Subject: Re: [PATCH] drm: msm: Fix build when legacy fbdev support isn't set From: Rob Clark To: Archit Taneja Cc: "dri-devel@lists.freedesktop.org" , linux-arm-msm , Linux Kernel Mailing List , Daniel Vetter Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2026 Lines: 58 On Mon, Feb 23, 2015 at 5:29 AM, Archit Taneja wrote: > The DRM_KMS_FB_HELPER config is selected only when DRM_MSM_FBDEV config is > selected. The driver accesses drm_fb_helper_* functions even when legacy fbdev > support is disabled in msm. Wrap around these functions with #ifdef checks to > prevent build break. hmm, perhaps rather than solving this in each driver, we should do some stub versions of those fb-helper fxns? There are at least one or two other drivers that can build without fbdev, and I guess more going forward.. BR, -R > Signed-off-by: Archit Taneja > --- > drivers/gpu/drm/msm/msm_drv.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c > index a426911..f15494c 100644 > --- a/drivers/gpu/drm/msm/msm_drv.c > +++ b/drivers/gpu/drm/msm/msm_drv.c > @@ -21,9 +21,11 @@ > > static void msm_fb_output_poll_changed(struct drm_device *dev) > { > +#ifdef CONFIG_DRM_MSM_FBDEV > struct msm_drm_private *priv = dev->dev_private; > if (priv->fbdev) > drm_fb_helper_hotplug_event(priv->fbdev); > +#endif > } > > static const struct drm_mode_config_funcs mode_config_funcs = { > @@ -373,9 +375,11 @@ static void msm_preclose(struct drm_device *dev, struct drm_file *file) > > static void msm_lastclose(struct drm_device *dev) > { > +#ifdef CONFIG_DRM_MSM_FBDEV > struct msm_drm_private *priv = dev->dev_private; > if (priv->fbdev) > drm_fb_helper_restore_fbdev_mode_unlocked(priv->fbdev); > +#endif > } > > static irqreturn_t msm_irq(int irq, void *arg) > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > hosted by The Linux Foundation > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/