From: Matt Fleming <matt@codeblueprint.co.uk>
Date: Mon, 23 Feb 2015 13:42:43 +0000
To: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
Cc: ard.biesheuvel@linaro.org, leif.lindholm@linaro.org,
        linux-kernel@vger.kernel.org
Subject: Re: [Patch v2 1/3] firmware: dmi_scan: fix dmi_len type
Message-ID: <20150223134243.GB19367@codeblueprint.co.uk>
References: <1424259201-24886-1-git-send-email-ivan.khoronzhuk@linaro.org>
 <1424259201-24886-2-git-send-email-ivan.khoronzhuk@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1424259201-24886-2-git-send-email-ivan.khoronzhuk@linaro.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1082
Lines: 25

On Wed, 18 Feb, at 01:33:19PM, Ivan Khoronzhuk wrote:
> According to SMBIOSv3 specification the length of DMI table can be
> up to 32bits wide. So use appropriate type to avoid overflow.
> 
> It's obvious that dmi_num theoretically can be more than u16 also,
> so it's can be changed to u32 or at least it's better to use int
> instead of u16, but on that moment I cannot imagine dmi structure
> count more than 65535 and it can require changing type of vars that
> work with it. So I didn't correct it.
> 
> Acked-by: Ard Biesheuvel <ard@linaro.org>
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
> ---
>  drivers/firmware/dmi_scan.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied to the 'urgent' EFI branch and tagged for stable. Thanks Ivan.

-- 
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/