Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752789AbbBWNz3 (ORCPT ); Mon, 23 Feb 2015 08:55:29 -0500 Received: from mail-wi0-f177.google.com ([209.85.212.177]:58913 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752070AbbBWNz0 (ORCPT ); Mon, 23 Feb 2015 08:55:26 -0500 Date: Mon, 23 Feb 2015 13:55:23 +0000 From: Matt Fleming To: Ivan Khoronzhuk Cc: ard.biesheuvel@linaro.org, leif.lindholm@linaro.org, linux-kernel@vger.kernel.org Subject: Re: [Patch v2 3/3] firmware: dmi_scan: use direct access to static vars Message-ID: <20150223135523.GD19367@codeblueprint.co.uk> References: <1424259201-24886-1-git-send-email-ivan.khoronzhuk@linaro.org> <1424259201-24886-4-git-send-email-ivan.khoronzhuk@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1424259201-24886-4-git-send-email-ivan.khoronzhuk@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 842 Lines: 22 On Wed, 18 Feb, at 01:33:21PM, Ivan Khoronzhuk wrote: > There is no reason to pass static vars to function that can use > only them. > > The dmi_table() can use only dmi_len and dmi_num static vars, so use > them directly. In this case we can freely change their type in one > place and slightly decrease redundancy. > > Signed-off-by: Ivan Khoronzhuk > --- > drivers/firmware/dmi_scan.c | 17 +++++++++-------- > 1 file changed, 9 insertions(+), 8 deletions(-) Applied to the EFI 'next' branch, thanks Ivan. -- Matt Fleming, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/