From: "Skidmore, Donald C" <donald.c.skidmore@intel.com>
To: Edward Cree <ecree@solarflare.com>
CC: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>,
        "vyasevic@redhat.com" <vyasevic@redhat.com>,
        "Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
        Alexander Duyck <alexander.duyck@gmail.com>,
        =?utf-8?B?QmrDuHJuIE1vcms=?= <bjorn@mork.no>,
        "e1000-devel@lists.sourceforge.net" 
	<e1000-devel@lists.sourceforge.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "Choi, Sy Jong" <sy.jong.choi@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        David Laight <David.Laight@ACULAB.COM>,
        Hayato Momma <h-momma@ce.jp.nec.com>
Subject: RE: [PATCH v2 2/3] if_link: Add VF multicast promiscuous control
Thread-Topic: [PATCH v2 2/3] if_link: Add VF multicast promiscuous control
Thread-Index: AdBMqJo0/LLpsu2NTFaRZnHct8YppwArslAAAAJM5JAAlJwDgAAPlXhQ
Date: Mon, 23 Feb 2015 14:29:43 +0000
Message-ID: <F6FB0E698C9B3143BDF729DF22286646912ADAD5@ORSMSX110.amr.corp.intel.com>
References: <7F861DC0615E0C47A872E6F3C5FCDDBD05E38840@BPXM14GP.gisp.nec.co.jp>
 <54E73BE4.2040505@solarflare.com>
 <F6FB0E698C9B3143BDF729DF22286646912AD3E7@ORSMSX110.amr.corp.intel.com>
 <54EB30A1.9080309@solarflare.com>
In-Reply-To: <54EB30A1.9080309@solarflare.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit
Content-Length: 2196
Lines: 34

> -----Original Message-----
> From: Edward Cree [mailto:ecree@solarflare.com]
> Sent: Monday, February 23, 2015 5:53 AM
> To: Skidmore, Donald C
> Cc: Hiroshi Shimamoto; vyasevic@redhat.com; Kirsher, Jeffrey T; Alexander
> Duyck; Bjørn Mork; e1000-devel@lists.sourceforge.net;
> netdev@vger.kernel.org; Choi, Sy Jong; linux-kernel@vger.kernel.org; David
> Laight; Hayato Momma
> Subject: Re: [PATCH v2 2/3] if_link: Add VF multicast promiscuous control
> 
> On 20/02/15 21:05, Skidmore, Donald C wrote:
> > If a vender specific interface is objectionable maybe a simpler and more
> generic interface would be for the PF to be able to set a given VF into
> "trusted" mode... I admit exactly what 'trusted' meant would vary from
> vender to vender, but it would be a way for the driver to know it could allow
> configurations such as this.  Just an idea, since we seem to be getting more
> requests for things such as this.
> That's an even worse idea; now you have a generic interface with completely
> undefined semantics.
> The right way to do this, imho, is to use one of the standard interfaces for
> driver-specific gubbins - e.g. sysfs, genetlink or even (whisper it) ioctls - and
> put your 'VF promisc mode' setting there.  That way you have a vendor-
> specific interface with vendor-specified semantics.
> Of those options, I'd recommend sysfs as the best fit.
> The information contained in this message is confidential and is intended for
> the addressee(s) only. If you have received this message in error, please
> notify the sender immediately and delete the message. Unless you are an
> addressee (or authorized to receive for an addressee), you may not use,
> copy or disclose to anyone this message or any information contained in this
> message. The unauthorized use, disclosure, copying or alteration of this
> message is strictly prohibited.

I do see your point, but I thought custom sysfs interfaces (not to even mention new ioctl's :) were frowned upon?  Which is why I didn't even consider sysfs as an option.
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?