Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752758AbbBWQB2 (ORCPT ); Mon, 23 Feb 2015 11:01:28 -0500 Received: from mga02.intel.com ([134.134.136.20]:41433 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752247AbbBWQBZ (ORCPT ); Mon, 23 Feb 2015 11:01:25 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,631,1418112000"; d="scan'208";a="458398049" Date: Mon, 23 Feb 2015 16:01:23 +0000 (UTC) From: Keith Busch X-X-Sender: vmware@localhost.lm.intel.com To: Arnd Bergmann cc: Jens Axboe , Keith Busch , linux-nvme@lists.infradead.org, Matthew Wilcox , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] NVMe: add explicit BLK_DEV_INTEGRITY dependency In-Reply-To: <6241161.LKiT8yUlIj@wuerfel> Message-ID: References: <6241161.LKiT8yUlIj@wuerfel> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1322 Lines: 26 On Mon, 23 Feb 2015, Arnd Bergmann wrote: > A patch that was added to 4.0-rc1 in the last minute caused a > build break in the NVMe driver unless integrity support is > also enabled: > > drivers/block/nvme-core.c: In function 'nvme_dif_remap': > drivers/block/nvme-core.c:523:24: error: dereferencing pointer to incomplete type > pmap = kmap_atomic(bip->bip_vec->bv_page) + bip->bip_vec->bv_offset; > ^ > drivers/block/nvme-core.c:523:49: error: dereferencing pointer to incomplete type > pmap = kmap_atomic(bip->bip_vec->bv_page) + bip->bip_vec->bv_offset; > ^ > > This changes the Kconfig entry for NVMe to depend on that > support, to avoid the build error. Using 'select' would work > as well, but might have unintended side-effects when users > do not actually want the integerity support. Thanks for the catch. We do want users to be able to use this with and without blk-integrity, so I'll send a patch using conditional functions between appropriate ifdef's like how scsi and block handle this. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/