Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753063AbbBWQJf (ORCPT ); Mon, 23 Feb 2015 11:09:35 -0500 Received: from mail-lb0-f175.google.com ([209.85.217.175]:46894 "EHLO mail-lb0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751898AbbBWQJe (ORCPT ); Mon, 23 Feb 2015 11:09:34 -0500 MIME-Version: 1.0 In-Reply-To: <1424707260-4302-1-git-send-email-boris.ostrovsky@oracle.com> References: <1424707260-4302-1-git-send-email-boris.ostrovsky@oracle.com> From: Andy Lutomirski Date: Mon, 23 Feb 2015 08:09:12 -0800 Message-ID: Subject: Re: [PATCH] x86/xen: Initialize cr4 shadow for 64-bit PV(H) guests To: Boris Ostrovsky Cc: Konrad Rzeszutek Wilk , David Vrabel , "xen-devel@lists.xenproject.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1317 Lines: 46 On Mon, Feb 23, 2015 at 8:01 AM, Boris Ostrovsky wrote: > Commit 1e02ce4cccdc ("x86: Store a per-cpu shadow copy of CR4") > introduced CR4 shadows. > > These shadows are initialized in early boot code. The commit missed > initialization for 64-bit PV(H) guests that this patch adds. Whoops, worry. This is needed for 3.21, right? --Andy > > Signed-off-by: Boris Ostrovsky > --- > arch/x86/xen/enlighten.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c > index bd8b845..7393f3e 100644 > --- a/arch/x86/xen/enlighten.c > +++ b/arch/x86/xen/enlighten.c > @@ -1741,6 +1741,7 @@ asmlinkage __visible void __init xen_start_kernel(void) > #ifdef CONFIG_X86_32 > i386_start_kernel(); > #else > + cr4_init_shadow(); /* 32b kernel does this in i386_start_kernel() */ > x86_64_start_reservations((char *)__pa_symbol(&boot_params)); > #endif > } > -- > 1.7.1 > -- Andy Lutomirski AMA Capital Management, LLC -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/