Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752791AbbBWQQc (ORCPT ); Mon, 23 Feb 2015 11:16:32 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:31240 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751812AbbBWQQb (ORCPT ); Mon, 23 Feb 2015 11:16:31 -0500 Message-ID: <54EB5258.9040705@oracle.com> Date: Mon, 23 Feb 2015 11:16:24 -0500 From: Boris Ostrovsky User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Andy Lutomirski CC: Konrad Rzeszutek Wilk , David Vrabel , "xen-devel@lists.xenproject.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] x86/xen: Initialize cr4 shadow for 64-bit PV(H) guests References: <1424707260-4302-1-git-send-email-boris.ostrovsky@oracle.com> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1425 Lines: 49 On 02/23/2015 11:09 AM, Andy Lutomirski wrote: > On Mon, Feb 23, 2015 at 8:01 AM, Boris Ostrovsky > wrote: >> Commit 1e02ce4cccdc ("x86: Store a per-cpu shadow copy of CR4") >> introduced CR4 shadows. >> >> These shadows are initialized in early boot code. The commit missed >> initialization for 64-bit PV(H) guests that this patch adds. > Whoops, worry. > > This is needed for 3.21, right? It would have been 3.20, I think. Which is now 4.0. -boris > > --Andy > >> Signed-off-by: Boris Ostrovsky >> --- >> arch/x86/xen/enlighten.c | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c >> index bd8b845..7393f3e 100644 >> --- a/arch/x86/xen/enlighten.c >> +++ b/arch/x86/xen/enlighten.c >> @@ -1741,6 +1741,7 @@ asmlinkage __visible void __init xen_start_kernel(void) >> #ifdef CONFIG_X86_32 >> i386_start_kernel(); >> #else >> + cr4_init_shadow(); /* 32b kernel does this in i386_start_kernel() */ >> x86_64_start_reservations((char *)__pa_symbol(&boot_params)); >> #endif >> } >> -- >> 1.7.1 >> > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/