Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753159AbbBWQqd (ORCPT ); Mon, 23 Feb 2015 11:46:33 -0500 Received: from bhuna.collabora.co.uk ([93.93.135.160]:46956 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753083AbbBWQq3 (ORCPT ); Mon, 23 Feb 2015 11:46:29 -0500 Message-ID: <54EB5959.90606@collabora.co.uk> Date: Mon, 23 Feb 2015 17:46:17 +0100 From: Javier Martinez Canillas User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.2.0 MIME-Version: 1.0 To: Sylwester Nawrocki , =?UTF-8?B?QW5kcmVhcyBGw6Q=?= =?UTF-8?B?cmJlcg==?= CC: Doug Anderson , alsa-devel@alsa-project.org, linux-samsung-soc , Sangbeom Kim , Liam Girdwood , Mark Brown , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Vincent Palatin , Tomasz Figa , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala Subject: Re: [PATCH 1/6] ASoC: max98088: Document DT bindings References: <1424283959-16289-1-git-send-email-afaerber@suse.de> <1424283959-16289-2-git-send-email-afaerber@suse.de> <54E5EB36.9020007@collabora.co.uk> <54E5EF73.2090302@suse.de> <54E62E1C.4030105@suse.de> <54E6314E.5060509@suse.de> <54E64C09.5000505@collabora.co.uk> <54E681A8.6040702@suse.de> <54E7249F.2020900@samsung.com> In-Reply-To: <54E7249F.2020900@samsung.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1576 Lines: 37 Hello Sylwester, On 02/20/2015 01:12 PM, Sylwester Nawrocki wrote: > On 20/02/15 01:36, Andreas Färber wrote: >>>> >> So it seems the mclk is not always set up properly by the kernel, >>>> >> relying on firmware. Who's in charge of setting that clock up? >>> > >>> > Right, it seems audio is only working due the firmware doing some previous >>> > setup. Probably it works on every boot if you have "sound init" as a part of >>> > the u-boot boot commands? >> >> Indeed it does, 24 MHz without the reparenting patch, and sound working. > > You can have parent of the CLKOUT clock set by the clk core if it is > specified in device tree in the PMU (the clkout clock supplier) device > node. > > Similarly as we did for the Odroix U3: > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/exynos4412-odroid-common.dtsi#n39 > > Relying on the clk_set_rate() to set the parent clock is not optimal > IMO. Presumably you need to set select stable parent clock for clkout > like XXTI. But I'm not very familiar with exyno5250 and that might be > something different. > Thanks a lot for your suggestion. I'll drop Tushar's patch to allow clkout to be reparent during set_rate then and change his DTS patch to set a default parent for CLKOUT using "assigned-clock-parents". Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/