Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753074AbbBWQuH (ORCPT ); Mon, 23 Feb 2015 11:50:07 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:34019 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752194AbbBWQuF (ORCPT ); Mon, 23 Feb 2015 11:50:05 -0500 Date: Mon, 23 Feb 2015 17:49:57 +0100 From: Peter Zijlstra To: kan.liang@intel.com Cc: linux-kernel@vger.kernel.org, mingo@redhat.com, acme@kernel.org, ak@linux.intel.com Subject: Re: [RFC PATCH 1/1] proc: introduce /proc//lbr_stack Message-ID: <20150223164957.GB5029@twins.programming.kicks-ass.net> References: <1424663021-82663-1-git-send-email-kan.liang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1424663021-82663-1-git-send-email-kan.liang@intel.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 933 Lines: 20 On Mon, Feb 23, 2015 at 03:43:41AM +0000, kan.liang@intel.com wrote: > From: Kan Liang > > Haswell has a new feature that utilizes the existing Last Branch Record > facility to record call chains. It has been implemented in perf. The > call chains information is saved during perf event context. > > This patch exposes a /proc//lbr_stack file that shows the saved LBR > call chain information. But why? I mean, this thing is only useful if you have a concurrently running perf record that selects the LBR-stack stuff. And if you have that, you might as well look at its output instead. Why add this unconditional proc file that doesn't function on its own? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/