Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752445AbbBWRR4 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 23 Feb 2015 12:17:56 -0500
Received: from smtprelay0104.hostedemail.com ([216.40.44.104]:55670 "EHLO
	smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1751812AbbBWRRy (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 23 Feb 2015 12:17:54 -0500
X-Session-Marker: 6E657665747340676F6F646D69732E6F7267
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:988:989:1260:1277:1311:1313:1314:1345:1359:1431:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:3874:4321:5007:6261:7875:10004:10400:10848:10967:11026:11232:11473:11658:11914:12043:12296:12517:12519:12555:12663:12740:13069:13311:13357:14096:14097:21060:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0
X-HE-Tag: home54_7efad10886500
X-Filterd-Recvd-Size: 2056
Date: Mon, 23 Feb 2015 12:17:51 -0500
From: Steven Rostedt <rostedt@goodmis.org>
To: Adrien Schildknecht <adrien+dev@schischi.me>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org,
        srostedt@redhat.com, luto@amacapital.net, bp@alien8.de,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86_64: use kstack_end() in dumpstack_64.c
Message-ID: <20150223121751.3fbb0885@gandalf.local.home>
In-Reply-To: <1424618638-6375-1-git-send-email-adrien+dev@schischi.me>
References: <1424618638-6375-1-git-send-email-adrien+dev@schischi.me>
X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1317
Lines: 42

On Sun, 22 Feb 2015 16:23:58 +0100
Adrien Schildknecht <adrien+dev@schischi.me> wrote:

> i386 is already using kstack_end() in dumpstack_32.c.
> We should also use it to make the code clearer and unify the stack
> printing logic some more.

Looks fine to me.

> 
> This patch depends on patch "x86: fix output of show_stack_log_lvl()"

I'm curious to what the dependency is? What would break if we apply
this without that patch?

-- Steve

> 
> Signed-off-by: Adrien Schildknecht <adrien+dev@schischi.me>
> ---
>  arch/x86/kernel/dumpstack_64.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/dumpstack_64.c b/arch/x86/kernel/dumpstack_64.c
> index 553573b..5f1c626 100644
> --- a/arch/x86/kernel/dumpstack_64.c
> +++ b/arch/x86/kernel/dumpstack_64.c
> @@ -280,7 +280,7 @@ show_stack_log_lvl(struct task_struct *task, struct pt_regs *regs,
>  				pr_cont(" <EOI> ");
>  			}
>  		} else {
> -		if (((long) stack & (THREAD_SIZE-1)) == 0)
> +		if (kstack_end(stack))
>  			break;
>  		}
>  		if ((i % STACKSLOTS_PER_LINE) == 0) {

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/