Date: Mon, 23 Feb 2015 12:20:36 -0500
From: Steven Rostedt <rostedt@goodmis.org>
To: Joe Perches <joe@perches.com>
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
        Andrew Morton <akpm@linux-foundation.org>,
        Ingo Molnar <mingo@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 24/27] tracing: Remove use of seq_printf return value
Message-ID: <20150223122036.4e8f34fb@gandalf.local.home>
In-Reply-To: <1424601578.20944.12.camel@perches.com>
References: <cover.1424573328.git.joe@perches.com>
	<175dfb0fba2847cb32fb4c9bb1d3f89643993414.1424573328.git.joe@perches.com>
	<20150221225409.417968db@grimm.local.home>
	<20150222044144.GD29656@ZenIV.linux.org.uk>
	<1424601578.20944.12.camel@perches.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1155
Lines: 34

On Sun, 22 Feb 2015 02:39:38 -0800
Joe Perches <joe@perches.com> wrote:

> > FWIW, this one should be Cc:stable - it's a plain and simple bugfix
> > (so are all of those that used to return the result of seq_printf() from
> > ->show()).
> 
> Nah, it's not really a bugfix here.
> 
> Patches sent to stable should fix actual bugs or failures.
> 
> Sure, it's a defect, but it's only a logical one, not an
> actual one.  It doesn't/can't fail in practice.
> 
> This is only a single symbol and so it can't overflow the
> initial allocation.
> 
> Besides that, the return value of the containing function
> is ignored.
> 

Right, there's nothing that will actually break with the current code.
The return value is ignored in the one place it is used. And no new
code is going to expect a result.

It's a fix that's fine for the next merge window. It's not even
important enough to get into this window.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/