Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752413AbbBWRgb (ORCPT <rfc822;w@1wt.eu>);
	Mon, 23 Feb 2015 12:36:31 -0500
Received: from smtprelay0136.hostedemail.com ([216.40.44.136]:48847 "EHLO
	smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1751812AbbBWRga (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 23 Feb 2015 12:36:30 -0500
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:334:355:368:369:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2689:2693:2828:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3872:3874:4321:5007:6261:10004:10400:10848:10967:11232:11658:11914:12517:12519:12740:13069:13311:13357:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0
X-HE-Tag: leaf36_8fa4753789c48
X-Filterd-Recvd-Size: 2374
Message-ID: <1424712985.20944.33.camel@perches.com>
Subject: Re: [PATCH 24/27] tracing: Remove use of seq_printf return value
From: Joe Perches <joe@perches.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
        Andrew Morton <akpm@linux-foundation.org>,
        Ingo Molnar <mingo@redhat.com>, linux-kernel@vger.kernel.org
Date: Mon, 23 Feb 2015 09:36:25 -0800
In-Reply-To: <20150223122036.4e8f34fb@gandalf.local.home>
References: <cover.1424573328.git.joe@perches.com>
	 <175dfb0fba2847cb32fb4c9bb1d3f89643993414.1424573328.git.joe@perches.com>
	 <20150221225409.417968db@grimm.local.home>
	 <20150222044144.GD29656@ZenIV.linux.org.uk>
	 <1424601578.20944.12.camel@perches.com>
	 <20150223122036.4e8f34fb@gandalf.local.home>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.12.7-0ubuntu1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1449
Lines: 41

On Mon, 2015-02-23 at 12:20 -0500, Steven Rostedt wrote:
> On Sun, 22 Feb 2015 02:39:38 -0800
> Joe Perches <joe@perches.com> wrote:
> 
> > > FWIW, this one should be Cc:stable - it's a plain and simple bugfix
> > > (so are all of those that used to return the result of seq_printf() from
> > > ->show()).
> > 
> > Nah, it's not really a bugfix here.
> > 
> > Patches sent to stable should fix actual bugs or failures.
> > 
> > Sure, it's a defect, but it's only a logical one, not an
> > actual one.  It doesn't/can't fail in practice.
> > 
> > This is only a single symbol and so it can't overflow the
> > initial allocation.
> > 
> > Besides that, the return value of the containing function
> > is ignored.
> > 
> 
> Right, there's nothing that will actually break with the current code.
> The return value is ignored in the one place it is used. And no new
> code is going to expect a result.
> 
> It's a fix that's fine for the next merge window. It's not even
> important enough to get into this window.

All of these "int->void seq_<foo>" changes are for 4.1
or whatever the next version is going to be called.

And I think date based kernel versioning like <yyyy.mm.v>
would have been better.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/