Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752841AbbBWRov (ORCPT ); Mon, 23 Feb 2015 12:44:51 -0500 Received: from mga03.intel.com ([134.134.136.65]:20786 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752679AbbBWRot (ORCPT ); Mon, 23 Feb 2015 12:44:49 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,631,1418112000"; d="scan'208";a="682120622" Date: Mon, 23 Feb 2015 09:44:48 -0800 From: Andi Kleen To: Peter Zijlstra Cc: kan.liang@intel.com, linux-kernel@vger.kernel.org, mingo@redhat.com, acme@kernel.org Subject: Re: [RFC PATCH 1/1] proc: introduce /proc//lbr_stack Message-ID: <20150223174448.GE27767@tassilo.jf.intel.com> References: <1424663021-82663-1-git-send-email-kan.liang@intel.com> <20150223164957.GB5029@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150223164957.GB5029@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1144 Lines: 28 On Mon, Feb 23, 2015 at 05:49:57PM +0100, Peter Zijlstra wrote: > On Mon, Feb 23, 2015 at 03:43:41AM +0000, kan.liang@intel.com wrote: > > From: Kan Liang > > > > Haswell has a new feature that utilizes the existing Last Branch Record > > facility to record call chains. It has been implemented in perf. The > > call chains information is saved during perf event context. > > > > This patch exposes a /proc//lbr_stack file that shows the saved LBR > > call chain information. > > But why? I mean, this thing is only useful if you have a concurrently > running perf record that selects the LBR-stack stuff. > > And if you have that, you might as well look at its output instead. Why > add this unconditional proc file that doesn't function on its own? perf record doesn't show where you're currently blocked. -Andi -- ak@linux.intel.com -- Speaking for myself only -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/