Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753304AbbBWVuL (ORCPT ); Mon, 23 Feb 2015 16:50:11 -0500 Received: from mail-la0-f44.google.com ([209.85.215.44]:38837 "EHLO mail-la0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752120AbbBWVuJ convert rfc822-to-8bit (ORCPT ); Mon, 23 Feb 2015 16:50:09 -0500 From: Rasmus Villemoes To: Yury Norov Cc: linux@horizon.com, klimov.linux@gmail.com, akpm@linux-foundation.org, davem@davemloft.net, dborkman@redhat.com, hannes@stressinduktion.org, laijs@cn.fujitsu.com, msalter@redhat.com, takahiro.akashi@linaro.org, tgraf@suug.ch, valentinrothberg@gmail.com, linux-kernel@vger.kernel.org, chris@chris-wilson.co.uk Subject: Re: [PATCH v5 1/3] lib: find_*_bit reimplementation Organization: D03 References: <1423404619-10653-1-git-send-email-yury.norov@gmail.com> <1424625857-19354-1-git-send-email-yury.norov@gmail.com> <1424625857-19354-2-git-send-email-yury.norov@gmail.com> X-Hashcash: 1:20:150223:chris@chris-wilson.co.uk::NK7RibLqGSRxOBFm:00000000000000000000000000000000000000sJ/ X-Hashcash: 1:20:150223:linux-kernel@vger.kernel.org::zMkplQAYQNB3+WgO:0000000000000000000000000000000000Iij X-Hashcash: 1:20:150223:tgraf@suug.ch::0owj2YuDSH9+q6qG:00000ZUh X-Hashcash: 1:20:150223:msalter@redhat.com::7FncDgxx9OYD82js:00000000000000000000000000000000000000000001S2e X-Hashcash: 1:20:150223:hannes@stressinduktion.org::8y4HFTMrPapihZ/F:000000000000000000000000000000000000NgC X-Hashcash: 1:20:150223:dborkman@redhat.com::H04wqpK69NFBJzjY:0000000000000000000000000000000000000000001Mvu X-Hashcash: 1:20:150223:davem@davemloft.net::5LzWxPSU8AOYeHdM:0000000000000000000000000000000000000000000EAW X-Hashcash: 1:20:150223:akpm@linux-foundation.org::imzRc10/0eway2nn:0000000000000000000000000000000000000bDd X-Hashcash: 1:20:150223:klimov.linux@gmail.com::0lV7dksV+0VnedrE:00000000000000000000000000000000000000002KK X-Hashcash: 1:20:150223:linux@horizon.com::ub2UtHEHpQg0d0bT:000000000000000000000000000000000000000000001LMU X-Hashcash: 1:20:150223:yury.norov@gmail.com::867NYZX0UwvEFIWm:000000000000000000000000000000000000000000jfU X-Hashcash: 1:20:150223:laijs@cn.fujitsu.com::TMquz7U+8m5qOlF5:000000000000000000000000000000000000000001+1F X-Hashcash: 1:20:150223:valentinrothberg@gmail.com::qLhKbn/imJA5gEo3:0000000000000000000000000000000000027GT X-Hashcash: 1:20:150223:takahiro.akashi@linaro.org::1uX8CrgnLPw6NURU:00000000000000000000000000000000000GTxy Date: Mon, 23 Feb 2015 22:50:04 +0100 In-Reply-To: <1424625857-19354-2-git-send-email-yury.norov@gmail.com> (Yury Norov's message of "Sun, 22 Feb 2015 20:24:15 +0300") Message-ID: <87oaok70xf.fsf@rasmusvillemoes.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1178 Lines: 28 On Sun, Feb 22 2015, Yury Norov wrote: > New implementations takes less space in source file (see diffstat) > and in object. For me it's 710 vs 453 bytes of text. > It also shows better performance. > > find_last_bit description fixed due to obvious typo. > Hm, sorry, I should probably have reminded you to include linux/bitmap.h: lib/find_last_bit.c: In function ‘find_last_bit’: lib/find_last_bit.c:25:3: error: implicit declaration of function ‘BITMAP_LAST_WORD_MASK’ [-Werror=implicit-function-declaration] lib/find_next_bit.c: In function ‘_find_next_bit’: lib/find_next_bit.c:37:2: error: implicit declaration of function ‘BITMAP_FIRST_WORD_MASK’ [-Werror=implicit-function-declaration] cc1: some warnings being treated as errors cc1: some warnings being treated as errors With that fixed: Reviewed-by: Rasmus Villemoes That also applies to 2/3 and 3/3. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/