Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752351AbbBXALB (ORCPT ); Mon, 23 Feb 2015 19:11:01 -0500 Received: from galahad.ideasonboard.com ([185.26.127.97]:49739 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751712AbbBXAK7 (ORCPT ); Mon, 23 Feb 2015 19:10:59 -0500 From: Laurent Pinchart To: Lad Prabhakar Cc: Sakari Ailus , LMML , LKML Subject: Re: [PATCH 1/3] media: omap3isp: ispvideo: drop setting of vb2 buffer state to VB2_BUF_STATE_ACTIVE Date: Tue, 24 Feb 2015 02:12 +0200 Message-ID: <17811429.e5EH6tz6Dl@avalon> User-Agent: KMail/4.14.3 (Linux/3.18.7-gentoo; KDE/4.14.3; x86_64; ; ) In-Reply-To: <1424722773-20131-2-git-send-email-prabhakar.csengg@gmail.com> References: <1424722773-20131-1-git-send-email-prabhakar.csengg@gmail.com> <1424722773-20131-2-git-send-email-prabhakar.csengg@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1370 Lines: 44 Hi Prabhakar, Thank you for the patch. On Monday 23 February 2015 20:19:31 Lad Prabhakar wrote: > From: "Lad, Prabhakar" > > There isn't a need to assign the state of vb2_buffer to active > as this is already done by the core. > > Signed-off-by: Lad, Prabhakar Acked-by: Laurent Pinchart and queued to my tree. I still have to test the patch, I'll report any issue I can find. > --- > drivers/media/platform/omap3isp/ispvideo.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/media/platform/omap3isp/ispvideo.c > b/drivers/media/platform/omap3isp/ispvideo.c index 3fe9047..837018d 100644 > --- a/drivers/media/platform/omap3isp/ispvideo.c > +++ b/drivers/media/platform/omap3isp/ispvideo.c > @@ -524,7 +524,6 @@ struct isp_buffer *omap3isp_video_buffer_next(struct > isp_video *video) > > buf = list_first_entry(&video->dmaqueue, struct isp_buffer, > irqlist); > - buf->vb.state = VB2_BUF_STATE_ACTIVE; > > spin_unlock_irqrestore(&video->irqlock, flags); -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/