Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752279AbbBXHUU (ORCPT ); Tue, 24 Feb 2015 02:20:20 -0500 Received: from mail-we0-f174.google.com ([74.125.82.174]:39556 "EHLO mail-we0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750880AbbBXHUS (ORCPT ); Tue, 24 Feb 2015 02:20:18 -0500 Message-ID: <54EC262E.9010903@plexistor.com> Date: Tue, 24 Feb 2015 09:20:14 +0200 From: Boaz Harrosh User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Andy Lutomirski CC: Ingo Molnar , Ross Zwisler , X86 ML , linux-kernel , "Roger C. Pao" , Dan Williams , Thomas Gleixner , Linus Torvalds , linux-nvdimm , "H. Peter Anvin" , Matthew Wilcox , Christoph Hellwig , Andrew Morton , Vivek Goyal Subject: Re: [PATCH 2/3] resource: Add new flag IORESOURCE_WARN (64bit) References: <54EB1D33.3050107@plexistor.com> <54EB206E.4010009@plexistor.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2426 Lines: 62 On 02/23/2015 05:46 PM, Andy Lutomirski wrote: > On Mon, Feb 23, 2015 at 4:43 AM, Boaz Harrosh wrote: >> >> Resource providers set this flag if they want >> that request_region_XXX will print a warning in dmesg >> if this particular resource is locked by a driver. >> >> Thous acting as a Protocol Police about experimental >> devices that did not pass a comity approval. >> >> The warn print looks like this: >> [Feb22 19:59] resource: request unknown region [mem 0x100000000-0x1ffffffff] unkown-12 >> Where the unkown-12 is taken from the res->name >> >> The Only user of this flag is x86/kernel/e820.c that >> wants to WARN about UNKNOWN memory types. >> >> NOTE: This patch looks very simple, a bit flag >> communicates between a resource provider ie e820.c >> that a warning should be printed, and resource.c >> prints such a message, when the resource is locked >> for use. > > I'm not really convinced this is necessary. If you somehow manage to > reserve a physical address corresponding to an nvdimm, you probably > know what you're doing. I think so too but, Ingo asked for it and I understand how it can be useful > After all, no in-tree driver will do this by > default. What? why? I intend to send pmem upstream soon. For god's sake These devices are out there, lots of them, used everyday, since when do we keep people systems out-of-tree? And why because some comity did not anticipate that the DDR bus will be used for "something else". With PCI or any other bus I develop a new card, give it an ID, scan for it and use it. DDR no, I need to re-write my BIOS, god. I wish it was Linux that was scanning the DDR bus, who gives a *ck about BIOS. I thought it was you who pushed for Linux's scan of the DDR bus? DDR bus will be used for lots more then flat NvDIMM, we will see soon, and already see, lots of Devices off of the DDR bus which as nothing to do with memory. The BIOS and e820 better be put aside, we need a simple scan and ID for these devices and let upper drivers take care of them. What do you want to happen, that each new device needs to go through this ordeal all over again? > > --Andy > Free life Boaz -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/