Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752108AbbBXIFO (ORCPT ); Tue, 24 Feb 2015 03:05:14 -0500 Received: from mail-wg0-f54.google.com ([74.125.82.54]:35553 "EHLO mail-wg0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750748AbbBXIFM (ORCPT ); Tue, 24 Feb 2015 03:05:12 -0500 MIME-Version: 1.0 In-Reply-To: <7125910.hm5qgSJ3zA@avalon> References: <1424722773-20131-1-git-send-email-prabhakar.csengg@gmail.com> <1424722773-20131-3-git-send-email-prabhakar.csengg@gmail.com> <7125910.hm5qgSJ3zA@avalon> From: "Lad, Prabhakar" Date: Tue, 24 Feb 2015 08:04:40 +0000 Message-ID: Subject: Re: [PATCH 2/3] media: omap3isp: ispvideo: drop driver specific isp_video_fh To: Laurent Pinchart Cc: Sakari Ailus , LMML , LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1692 Lines: 54 Hi Laurent, Thanks for the review. On Tue, Feb 24, 2015 at 12:35 AM, Laurent Pinchart wrote: > Hi Prabhakar, > > Thank you for the patch. > > On Monday 23 February 2015 20:19:32 Lad Prabhakar wrote: >> From: "Lad, Prabhakar" >> >> this patch drops driver specific isp_video_fh, as this >> can be handled by core. > > I'm afraid it's not that simple. > > The omap3isp driver stores video queues per file handle for a reason. This was > design to permit creating a high-resolution still image capture queue and > prepare buffers ahead of time, to avoid the large delay due to cache > management as prepare time when taking the snapshot. > Ah I see the reason. > Now this use case has been partially solved by VIDIOC_CREATE_BUFS, but we're > still missing a VIDIOC_DESTROY_BUFS to make it work completely. That needs to > be solved first. > I haven't used the VIDIOC_CREATE_BUFS ioctl so far in any of the apps so cant comment much on this. But isn't that obvious we need VIDIOC_DESTROY_BUFS or is there any backdoor to destroy them that I am missing ? Regards, --Prabhakar Lad >> Signed-off-by: Lad, Prabhakar >> --- >> drivers/media/platform/omap3isp/ispvideo.c | 128 ++++++++++--------------- >> drivers/media/platform/omap3isp/ispvideo.h | 13 +-- >> 2 files changed, 49 insertions(+), 92 deletions(-) > > -- > Regards, > > Laurent Pinchart > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/