Date: Tue, 24 Feb 2015 00:40:49 -0800
From: Brian Norris <computersforpeace@gmail.com>
To: Felix Fietkau <nbd@openwrt.org>
Cc: Rodrigo Freire <rfreire@redhat.com>, linux-mtd@lists.infradead.org,
        linux-kernel@vger.kernel.org,
        =?iso-8859-1?Q?J=F6rn?= Engel <joern@logfs.org>, dwmw2@infradead.org,
        Herton Krzesinski <hkrzesin@redhat.com>
Subject: Re: [PATCH v3 3/3] mtd: block2mtd: Removes PAGE_MASK as a index to
 partition size
Message-ID: <20150224084049.GH24441@norris-Latitude-E6410>
References: <1807144344.40128259.1410985683342.JavaMail.zimbra@redhat.com>
 <20141105202303.GN23619@ld-irv-0074>
 <2086372266.7454667.1415535533979.JavaMail.zimbra@redhat.com>
 <1874445287.7454806.1415535792984.JavaMail.zimbra@redhat.com>
 <20141126072147.GO3212@norris-Latitude-E6410>
 <1417070032.4547583.1417007972343.JavaMail.zimbra@redhat.com>
 <20150224080752.GF24441@norris-Latitude-E6410>
 <54EC344F.3050709@openwrt.org>
 <20150224082725.GG24441@norris-Latitude-E6410>
 <54EC369D.7090108@openwrt.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <54EC369D.7090108@openwrt.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1465
Lines: 34

On Tue, Feb 24, 2015 at 09:30:21PM +1300, Felix Fietkau wrote:
> On 2015-02-24 21:27, Brian Norris wrote:
> > On Tue, Feb 24, 2015 at 09:20:31PM +1300, Felix Fietkau wrote:
> >> On 2015-02-24 21:07, Brian Norris wrote:
> >> > OK let's drop this patch from the series. At best, we could just do
> >> > something like this instead:
> >> > 
> >> > -	dev->mtd.size = dev->blkdev->bd_inode->i_size & PAGE_MASK;
> >> > +	dev->mtd.size = dev->blkdev->bd_inode->i_size;
> >> > 
> >> > But that's really just an unnecessary change.
> >> If I remember correctly, it was problematic to have a dev->mtd.size
> >> value which is not a multiple of the erase size. I think that was the
> >> reason for patch 3.
> > 
> > The what's this for?
> > 
> > 	if ((long)dev->blkdev->bd_inode->i_size % erase_size) {
> > 		pr_err("erasesize must be a divisor of device size\n");
> > 		goto err_free_block2mtd;
> > 	}
> I think we should just trim the mtd size to a multiple of erase size and
> remove this check. It is a bit impractical for many cases.

Well that's not the subject of anything in this series, and this patch
does not stand alone well, so I'm not taking it. Feel free to send a
different patch if you have good reason to.

Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/