Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752891AbbBXJGz (ORCPT ); Tue, 24 Feb 2015 04:06:55 -0500 Received: from galahad.ideasonboard.com ([185.26.127.97]:50154 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751433AbbBXJGx (ORCPT ); Tue, 24 Feb 2015 04:06:53 -0500 From: Laurent Pinchart To: "Lad, Prabhakar" Cc: Sakari Ailus , LMML , LKML Subject: Re: [PATCH 2/3] media: omap3isp: ispvideo: drop driver specific isp_video_fh Date: Tue, 24 Feb 2015 11:07:53 +0200 Message-ID: <1975486.DZ2Ir2MLZP@avalon> User-Agent: KMail/4.14.3 (Linux/3.18.7-gentoo; KDE/4.14.3; x86_64; ; ) In-Reply-To: References: <1424722773-20131-1-git-send-email-prabhakar.csengg@gmail.com> <7125910.hm5qgSJ3zA@avalon> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1818 Lines: 48 Hi Prabhakar, On Tuesday 24 February 2015 08:04:40 Lad, Prabhakar wrote: > On Tue, Feb 24, 2015 at 12:35 AM, Laurent Pinchart wrote: > > On Monday 23 February 2015 20:19:32 Lad Prabhakar wrote: > >> From: "Lad, Prabhakar" > >> > >> this patch drops driver specific isp_video_fh, as this > >> can be handled by core. > > > > I'm afraid it's not that simple. > > > > The omap3isp driver stores video queues per file handle for a reason. This > > was design to permit creating a high-resolution still image capture queue > > and prepare buffers ahead of time, to avoid the large delay due to cache > > management as prepare time when taking the snapshot. > > Ah I see the reason. > > > Now this use case has been partially solved by VIDIOC_CREATE_BUFS, but > > we're still missing a VIDIOC_DESTROY_BUFS to make it work completely. > > That needs to be solved first. > > I haven't used the VIDIOC_CREATE_BUFS ioctl so far in any of the apps > so cant comment much on this. > But isn't that obvious we need VIDIOC_DESTROY_BUFS or is there any backdoor > to destroy them that I am missing ? You can destroy buffers allocated with CREATE_BUFS using REQBUFS(0), but you can't destroy them individually without a new ioctl. > >> Signed-off-by: Lad, Prabhakar > >> --- > >> > >> drivers/media/platform/omap3isp/ispvideo.c | 128 +++++++++-------------- > >> drivers/media/platform/omap3isp/ispvideo.h | 13 +-- > >> 2 files changed, 49 http://vger.kernel.org/majordomo-info.html -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/