Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752360AbbBXLBO (ORCPT <rfc822;w@1wt.eu>);
	Tue, 24 Feb 2015 06:01:14 -0500
Received: from ns.mm-sol.com ([37.157.136.199]:42498 "EHLO extserv.mm-sol.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750748AbbBXLBM (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 24 Feb 2015 06:01:12 -0500
Message-ID: <1424775668.2340.15.camel@mm-sol.com>
Subject: Re: [PATCH V4 2/2] spmi: pmic_arb: add support for hw version 2
From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
To: Gilad Avidov <gavidov@codeaurora.org>
Cc: sdharia@codeaurora.org, mlocke@codeaurora.org,
        linux-arm-msm@vger.kernel.org, gregkh@linuxfoundation.org,
        linux-kernel@vger.kernel.org, galak@codeaurora.org,
        agross@codeaurora.org
Date: Tue, 24 Feb 2015 13:01:08 +0200
In-Reply-To: <1424386453-18092-3-git-send-email-gavidov@codeaurora.org>
References: <1424386453-18092-1-git-send-email-gavidov@codeaurora.org>
	 <1424386453-18092-3-git-send-email-gavidov@codeaurora.org>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.13.7-fta1.2~trusty 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1095
Lines: 36


Hi Gilad,

One more comment :-).

On Thu, 2015-02-19 at 15:54 -0700, Gilad Avidov wrote:

<snip>


-static int pmic_arb_wait_for_done(struct spmi_controller *ctrl)
+static int pmic_arb_wait_for_done(struct spmi_controller *ctrl,
+                                               void __iomem *base, u8 sid, u16 addr)
 {
        struct spmi_pmic_arb_dev *dev = spmi_controller_get_drvdata(ctrl);
        u32 status = 0;
        u32 timeout = PMIC_ARB_TIMEOUT_US;
-       u32 offset = PMIC_ARB_STATUS(dev->channel);
+       u32 offset = dev->ver_ops->offset(dev, sid, addr) + PMIC_ARB_STATUS;


        while (timeout--) {
                status = pmic_arb_base_read(dev, offset);

I see that downstream driver is using read or write base address
based on operation for which we are waiting (read_cmd/write_cmd).

Should this be reflected here?

Ivan.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/