Message-ID: <54EC643D.3040005@redhat.com>
Date: Tue, 24 Feb 2015 12:45:01 +0100
From: Denys Vlasenko <dvlasenk@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0
MIME-Version: 1.0
To: Andy Lutomirski <luto@amacapital.net>
CC: Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
        X86 ML <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Alexander van Heukelum <heukelum@fastmail.fm>
Subject: Re: RFC: (almost) getting rid of FIXUP/RESTORE_TOP_OF_STACK?
References: <54EB96AB.5050808@redhat.com> <CALCETrXCoQV5pq5J3ZmPywM-PnWMKp=CvayXkSDpSBoE24TRog@mail.gmail.com>
In-Reply-To: <CALCETrXCoQV5pq5J3ZmPywM-PnWMKp=CvayXkSDpSBoE24TRog@mail.gmail.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1544
Lines: 46

On 02/24/2015 12:58 AM, Andy Lutomirski wrote:
>> - Next possible change is to use PUSH insns to build the stack. Something along the lines of
>>         swapgs
>>         mov     %rsp,%gs:old_rsp
>>         mov     %gs:kernel_stack,%rsp
>>         sti
>>         push    $__USER_DS   /* pt_regs->ss */
>>         push    %gs:old_rsp  /* ->rsp */
>>         push    %r11         /* ->rflags */
>>         push    $__USER_CS   /* ->cs */
>>         push    %rcx         /* ->rip */
>>         push    %rax         /* ->orig_rax */
>>         push    %rdi
>>         push    %rsi
>>         push    %rdx
>>         push    %rcx
>>         push    $-ENOSYS     /* ->rax */
>>         push    %r8
>>         push    %r9
>>         push    %r10
>>         push    %r11
>>         sub     $(6*8),%rsp /* rbx, rbp, r12-r15 not saved */

Correction:
         push    %r11
         sub     $(6*8),%rsp /* rbx, rbp, r12-r15 not saved */
should be
         sub     $(7*8),%rsp /* r11, rbx, rbp, r12-r15 not saved */
since we don't need to save r11 either.

> 
> Yay!

"yay!" as in "I like this!" or as in "I am surprised" ?

>  Can we have a macro PUSH_XYZ for most of this?

Yes, it can be a macro. I'm not sure we'll have more than one
such place, tho.
Do you want a macro even if it will be once-use only?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/