Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753079AbbBXQTW (ORCPT ); Tue, 24 Feb 2015 11:19:22 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:19564 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752646AbbBXQTU (ORCPT ); Tue, 24 Feb 2015 11:19:20 -0500 Date: Tue, 24 Feb 2015 17:21:04 +0100 From: Quentin Casasnovas To: Borislav Petkov Cc: X86 ML , LKML , Quentin Casasnovas Subject: Re: [PATCH 03/13] x86/microcode/intel: Get rid of last arg to load_ucode_intel_bsp() Message-ID: <20150224162104.GD4565@chrystal.uk.oracle.com> References: <1424774232-5981-1-git-send-email-bp@alien8.de> <1424774232-5981-4-git-send-email-bp@alien8.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1424774232-5981-4-git-send-email-bp@alien8.de> User-Agent: Mutt/1.5.22 (2013-10-16) X-Source-IP: acsinet22.oracle.com [141.146.126.238] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 709 Lines: 18 On Tue, Feb 24, 2015 at 11:37:02AM +0100, Borislav Petkov wrote: > From: Borislav Petkov > > Allocate it on the helper's _load_ucode_intel_bsp() stack instead and do > not hand it down. > Going further, could you not even make uci a static global variable and have collect_cpu_info_early() called only _once_ to fill the information in, then you can remove the uci argument from all the other functions as well? Just a suggestion anyway. Quentin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/