Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753353AbbBXQWP (ORCPT ); Tue, 24 Feb 2015 11:22:15 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:21892 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752976AbbBXQWO (ORCPT ); Tue, 24 Feb 2015 11:22:14 -0500 Date: Tue, 24 Feb 2015 17:24:07 +0100 From: Quentin Casasnovas To: Borislav Petkov Cc: X86 ML , LKML , Quentin Casasnovas Subject: Re: [PATCH 10/13] x86/microcode/intel: Move mc arg last in get_matching_{microcode|sig} Message-ID: <20150224162407.GI4565@chrystal.uk.oracle.com> References: <1424774232-5981-1-git-send-email-bp@alien8.de> <1424774232-5981-11-git-send-email-bp@alien8.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1424774232-5981-11-git-send-email-bp@alien8.de> User-Agent: Mutt/1.5.22 (2013-10-16) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 777 Lines: 20 On Tue, Feb 24, 2015 at 11:37:09AM +0100, Borislav Petkov wrote: > @@ -153,16 +152,15 @@ int get_matching_sig(unsigned int csig, int cpf, void *mc, int rev) > } > > /* > - * return 0 - no update found > - * return 1 - found update > + * Returns 1 if update has been found, 0 otherwise. > */ > -int get_matching_microcode(unsigned int csig, int cpf, void *mc, int rev) > +int get_matching_microcode(unsigned int csig, int cpf, int rev, void *mc) Why not rename the function to is_microcode_matching() while at it? :) Quentin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/