Date: Tue, 24 Feb 2015 17:24:27 +0100
From: Quentin Casasnovas <quentin.casasnovas@oracle.com>
To: Borislav Petkov <bp@alien8.de>
Cc: X86 ML <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        Quentin Casasnovas <quentin.casasnovas@oracle.com>
Subject: Re: [PATCH 13/13] x86/microcode/intel: Fix printing of microcode
 blobs in show_saved_mc()
Message-ID: <20150224162427.GJ4565@chrystal.uk.oracle.com>
References: <1424774232-5981-1-git-send-email-bp@alien8.de>
 <1424774232-5981-14-git-send-email-bp@alien8.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1424774232-5981-14-git-send-email-bp@alien8.de>
User-Agent: Mutt/1.5.22 (2013-10-16)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 989
Lines: 29

On Tue, Feb 24, 2015 at 11:37:12AM +0100, Borislav Petkov wrote:
> 
> While at it, make pr_* stuff use "microcode: " prefix for easier
> grepping and document how to enable the DEBUG build.
> 
> +++ b/arch/x86/kernel/cpu/microcode/intel_early.c
> @@ -16,6 +16,14 @@
>   *	as published by the Free Software Foundation; either version
>   *	2 of the License, or (at your option) any later version.
>   */
> +
> +/*
> + * This needs to be before all headers so that pr_debug in printk.h doesn't turn
> + * printk calls into no_printk().
> + *
> + *#define DEBUG
> + */
> +

Hmm I might be completely wrong but I thought the whole point of pr_debug()
was to have something dynamic at runtime as opposed to compiled in?  What
am I missing?

Quentin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/