Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753074AbbBXQ4O (ORCPT ); Tue, 24 Feb 2015 11:56:14 -0500 Received: from mail-wi0-f178.google.com ([209.85.212.178]:57455 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752326AbbBXQ4L (ORCPT ); Tue, 24 Feb 2015 11:56:11 -0500 From: Ameen Ali To: schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, linux390@de.ibm.com, keescook@chromium.org, wsa@the-dreams.de Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Ameen Ali Subject: [PATCH] dcssblk.c : Array index 'i' is used before limits check. Date: Tue, 24 Feb 2015 18:41:50 +0200 Message-Id: <1424796110-7736-1-git-send-email-ameenali023@gmail.com> X-Mailer: git-send-email 2.1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1005 Lines: 28 avoid out-of-bounds-read by checking count before indexing. Signed-off-by : Ameen Ali --- drivers/s390/block/dcssblk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/s390/block/dcssblk.c b/drivers/s390/block/dcssblk.c index 96128cb..da21281 100644 --- a/drivers/s390/block/dcssblk.c +++ b/drivers/s390/block/dcssblk.c @@ -547,7 +547,7 @@ dcssblk_add_store(struct device *dev, struct device_attribute *attr, const char * parse input */ num_of_segments = 0; - for (i = 0; ((buf[i] != '\0') && (buf[i] != '\n') && i < count); i++) { + for (i = 0; (i < count && (buf[i] != '\0') && (buf[i] != '\n')); i++) { for (j = i; (buf[j] != ':') && (buf[j] != '\0') && (buf[j] != '\n') && -- 2.1.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/