Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753673AbbBXSVr (ORCPT ); Tue, 24 Feb 2015 13:21:47 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:56310 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753273AbbBXSVp (ORCPT ); Tue, 24 Feb 2015 13:21:45 -0500 Date: Tue, 24 Feb 2015 10:21:44 -0800 From: Stephen Boyd To: Georgi Djakov Cc: mturquette@linaro.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v1] clk: qcom: Add MSM8916 Global Clock Controller support Message-ID: <20150224182144.GG24928@codeaurora.org> References: <1423249118-22132-1-git-send-email-georgi.djakov@linaro.org> <54EBADB3.7030005@codeaurora.org> <54EC9D66.10001@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54EC9D66.10001@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1133 Lines: 38 On 02/24, Georgi Djakov wrote: > On 02/24/2015 12:46 AM, Stephen Boyd wrote: > > On 02/06/15 10:58, Georgi Djakov wrote: > > > >> + > >> + return qcom_cc_really_probe(pdev, &gcc_msm8916_desc, regmap); > >> +} > >> + > >> +static int gcc_msm8916_remove(struct platform_device *pdev) > >> +{ > >> + qcom_cc_remove(pdev); > >> + return 0; > >> +} > >> + > >> +static struct platform_driver gcc_msm8916_driver = { > >> + .probe = gcc_msm8916_probe, > >> + .remove = gcc_msm8916_remove, > >> + .driver = { > >> + .name = "gcc-msm8916", > > > > We need owner = THIS_MODULE here because the platform_driver_module > > macro isn't being used. > > > > But below i use the platform_driver_register macro and therefore it seems > not needed. > Ah ok, sorry for the confusion. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/