Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753656AbbBXS33 (ORCPT ); Tue, 24 Feb 2015 13:29:29 -0500 Received: from mail.skyhub.de ([78.46.96.112]:53532 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753118AbbBXS31 (ORCPT ); Tue, 24 Feb 2015 13:29:27 -0500 Date: Tue, 24 Feb 2015 19:30:23 +0100 From: Borislav Petkov To: Quentin Casasnovas Cc: X86 ML , LKML Subject: Re: [PATCH 03/13] x86/microcode/intel: Get rid of last arg to load_ucode_intel_bsp() Message-ID: <20150224183023.GJ3420@pd.tnic> References: <1424774232-5981-1-git-send-email-bp@alien8.de> <1424774232-5981-4-git-send-email-bp@alien8.de> <20150224162104.GD4565@chrystal.uk.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150224162104.GD4565@chrystal.uk.oracle.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 878 Lines: 22 On Tue, Feb 24, 2015 at 05:21:04PM +0100, Quentin Casasnovas wrote: > Going further, could you not even make uci a static global variable and > have collect_cpu_info_early() called only _once_ to fill the information > in, then you can remove the uci argument from all the other functions as > well? Just a suggestion anyway. Yeah, I could but this is not on a fast path and we want to, theoretically at least, support mixed revision microcode loading where the BSP and APs have different revisions. Thus the separate collect_cpu_info_early() calls. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/