Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753502AbbBXSbb (ORCPT ); Tue, 24 Feb 2015 13:31:31 -0500 Received: from mail.skyhub.de ([78.46.96.112]:58626 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753039AbbBXSba (ORCPT ); Tue, 24 Feb 2015 13:31:30 -0500 Date: Tue, 24 Feb 2015 19:32:26 +0100 From: Borislav Petkov To: Quentin Casasnovas Cc: X86 ML , LKML Subject: Re: [PATCH 04/13] x86/microcode/intel: Simplify load_ucode_intel_bsp() Message-ID: <20150224183226.GK3420@pd.tnic> References: <1424774232-5981-1-git-send-email-bp@alien8.de> <1424774232-5981-5-git-send-email-bp@alien8.de> <20150224162151.GE4565@chrystal.uk.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150224162151.GE4565@chrystal.uk.oracle.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 906 Lines: 27 On Tue, Feb 24, 2015 at 05:21:51PM +0100, Quentin Casasnovas wrote: > ... here `size = end - start + 1`, so basically the original size in > `hdr.ramdisk_image` *plus one*, whereas the `size` you're passing around > does not include it. I'm not saying it's wrong, quite the opposite I think > you're fixing an off-by-one error present in the original code at the same > time :) I know, right :-) I was scratching my head about it and if using the size directly is wrong then something's genuinely b0rked with the design of this thing. I'll correct the commit message. Tanks. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/