Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753542AbbBXTVV (ORCPT ); Tue, 24 Feb 2015 14:21:21 -0500 Received: from mail-pa0-f49.google.com ([209.85.220.49]:46953 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751824AbbBXTVS (ORCPT ); Tue, 24 Feb 2015 14:21:18 -0500 Date: Tue, 24 Feb 2015 15:21:11 -0400 From: Eduardo Valentin To: Lukasz Majewski Cc: Kamil Debski , Jean Delvare , Guenter Roeck , Kukjin Kim , lm-sensors@lm-sensors.org, Linux PM list , "linux-samsung-soc@vger.kernel.org" , devicetree@vger.kernel.org, Lukasz Majewski , Kukjin Kim , linux-kernel@vger.kernel.org, Sjoerd Simons , Abhilash Kesavan , Abhilash Kesavan Subject: Re: [PATCH v4 2/8] thermal: Provide stub for thermal_cdev_update() function Message-ID: <20150224192109.GG3448@developer.amazonguestwifi.org> References: <1418897591-18332-1-git-send-email-l.majewski@samsung.com> <1424254056-5904-1-git-send-email-l.majewski@samsung.com> <1424254056-5904-3-git-send-email-l.majewski@samsung.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="PyMzGVE0NRonI6bs" Content-Disposition: inline In-Reply-To: <1424254056-5904-3-git-send-email-l.majewski@samsung.com> User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3229 Lines: 95 --PyMzGVE0NRonI6bs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 18, 2015 at 11:07:30AM +0100, Lukasz Majewski wrote: > Odroid U3 fan can work without being registered as OF cooling device > (with CONFIG_THERMAL{_OF|} disabled). > In this situation it can be controlled via PWM entry at > /sys/class/hwmon/hwmon0/pwm1. >=20 > Therefore, the thermal_cdev_update() function needs a stub > to allow clean compilation. I've just applied a patch on this same matter from Nishanth Menon [1]. Can you please check if his patch is enough for you? [1] - https://git.kernel.org/cgit/linux/kernel/git/evalenti/linux-soc-thermal.git= /commit/?h=3Dfixes&id=3D12ca7188468ee29c4e717f73db4bf43c90954fc7 >=20 > Signed-off-by: Lukasz Majewski > --- > Changes for v2: > - New patch > Changes for v3: > - thermal_cdev_update() now depends on CONFIG_THERMAL flag > Changes for v4: > - None > --- > include/linux/thermal.h | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) >=20 > diff --git a/include/linux/thermal.h b/include/linux/thermal.h > index eacf2de..25382e6 100644 > --- a/include/linux/thermal.h > +++ b/include/linux/thermal.h > @@ -298,6 +298,7 @@ struct thermal_cooling_device * > thermal_of_cooling_device_register(struct device_node *np, > char *type, void *devdata, > const struct thermal_cooling_device_ops *); > +void thermal_cdev_update(struct thermal_cooling_device *); > #else > static inline struct thermal_cooling_device * > thermal_of_cooling_device_register(struct device_node *np, > @@ -306,6 +307,9 @@ thermal_of_cooling_device_register(struct device_node= *np, > { > return NULL; > } > +static inline void thermal_cdev_update(struct thermal_cooling_device *cd= ev) > +{ > +} > #endif > #ifdef CONFIG_THERMAL_OF > struct thermal_zone_device * > @@ -349,7 +353,6 @@ int thermal_zone_get_temp(struct thermal_zone_device = *tz, unsigned long *temp); > int get_tz_trend(struct thermal_zone_device *, int); > struct thermal_instance *get_thermal_instance(struct thermal_zone_device= *, > struct thermal_cooling_device *, int); > -void thermal_cdev_update(struct thermal_cooling_device *); > void thermal_notify_framework(struct thermal_zone_device *, int); > =20 > #ifdef CONFIG_NET > --=20 > 2.0.0.rc2 >=20 --PyMzGVE0NRonI6bs Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJU7M8aAAoJEMLUO4d9pOJW8k4H/jEF+Q+GzlaavuULZiqwHnyU Zzl4V4x/LhdTTUlmZD5VttjW+1YUTiYu/DFOss9RHiXGYRwiUJWypztt3SxtbC0x q4qdNxEd+6k0zE7c+9xTgBfiE+0MtdKxijUCMEG55XWvZO3IJuNLeNDIA6mU2gkD fQr0Hda1GTaLINcwJef/9V+K1lYCgi87d1HZ0BFeRmib5CJ5V1sco+oSmeax5J1U IwN1OKG5BB3sO6bQEyFpcBwIjKe3b1JorLu4Ib32F7ZxED04EcOktJ4wKmHNH7XT vmCqPpRX0t3c8tntIJxAkIgwEdWKvViDZXFJbclgTY83ZON7F0HVjimRihnU7dM= =YtLR -----END PGP SIGNATURE----- --PyMzGVE0NRonI6bs-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/