Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753400AbbBXTZb (ORCPT ); Tue, 24 Feb 2015 14:25:31 -0500 Received: from mail-pa0-f54.google.com ([209.85.220.54]:43277 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751824AbbBXTZ2 (ORCPT ); Tue, 24 Feb 2015 14:25:28 -0500 Date: Tue, 24 Feb 2015 15:25:21 -0400 From: Eduardo Valentin To: Lukasz Majewski Cc: Kamil Debski , Jean Delvare , Guenter Roeck , Kukjin Kim , lm-sensors@lm-sensors.org, Linux PM list , "linux-samsung-soc@vger.kernel.org" , devicetree@vger.kernel.org, Lukasz Majewski , Kukjin Kim , linux-kernel@vger.kernel.org, Sjoerd Simons , Abhilash Kesavan , Abhilash Kesavan Subject: Re: [PATCH v4 3/8] Documentation: dts: Documentation entry to explain how to use PWM FAN as a cooling device Message-ID: <20150224192520.GI3448@developer.amazonguestwifi.org> References: <1418897591-18332-1-git-send-email-l.majewski@samsung.com> <1424254056-5904-1-git-send-email-l.majewski@samsung.com> <1424254056-5904-4-git-send-email-l.majewski@samsung.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="7IgncvKP0CVPV/ZZ" Content-Disposition: inline In-Reply-To: <1424254056-5904-4-git-send-email-l.majewski@samsung.com> User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3108 Lines: 93 --7IgncvKP0CVPV/ZZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 18, 2015 at 11:07:31AM +0100, Lukasz Majewski wrote: > Explanation of several properties, which allow PWM fan working as a cooli= ng > device, have been embraced in this commit. >=20 > Signed-off-by: Lukasz Majewski > --- > Changes for v2: > - Rename cooling-pwm-values to cooling-levels > - Remove default-pulse-width property and stick to default hwmon policy > Changes for v3: > - Changing commit title from "hwmon: dts: Doc:" to "Documentation: dts" > - Remove unnecessary properties > - Set maximal cooling level to 230 instead of 255 > Changes for v4: > - None > --- > Documentation/devicetree/bindings/hwmon/pwm-fan.txt | 20 +++++++++++++++= +++++ > 1 file changed, 20 insertions(+) >=20 > diff --git a/Documentation/devicetree/bindings/hwmon/pwm-fan.txt b/Docume= ntation/devicetree/bindings/hwmon/pwm-fan.txt > index 610757c..d53fe0c 100644 > --- a/Documentation/devicetree/bindings/hwmon/pwm-fan.txt > +++ b/Documentation/devicetree/bindings/hwmon/pwm-fan.txt > @@ -3,10 +3,30 @@ Bindings for a fan connected to the PWM lines > Required properties: > - compatible : "pwm-fan" > - pwms : the PWM that is used to control the PWM fan > +- cooling-levels : PWM duty cycle values in a range from 0 to 255 > + which correspond to thermal cooling states > + > +Thorough description of the following bindings: > + cooling-min-state =3D <0>; > + cooling-max-state =3D <3>; > + #cooling-cells =3D <2>; > + thermal-zone { > + cpu_thermal: cpu-thermal { > + cooling-maps { > + map0 { > + trip =3D <&cpu_alert1>; > + cooling-device =3D <&fan0 0 1>; > + }; > + }; > + }; I am fine if you leave the reference to thermal.txt biding description, but I would prefer if you move the above lines to a proper example section. > + > +for PWM FAN used as cooling device can be found at: > +./Documentation/devicetree/bindings/thermal/thermal.txt > =20 > Example: > pwm-fan { > compatible =3D "pwm-fan"; > status =3D "okay"; > pwms =3D <&pwm 0 10000 0>; > + cooling-levels =3D <0 102 170 230>; > }; > --=20 > 2.0.0.rc2 >=20 --7IgncvKP0CVPV/ZZ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJU7NAWAAoJEMLUO4d9pOJWCAIH/0f3Y2wm25mlIgWvVB1zPEyD 357D2o77MaVTOrsHBB4qZ39/xZczRM2+MJkj4J2jS1Jc5vvdeRdJ9eRHsoxwTvma 0Prhw8dBHi7yzBLYefeBtsVuraHc3P6V8QXQhhnBgF0W4PIXT749KWoXPXc55f+q E1sk3Hp4TBm5SinUescBz+vktBglHYTmn/4RAW/ieZJmc5U4CwJ1bh692GNesONK E3jYbiuLjm9VbI5erVoZeF3MACMiulLpalZegBRmgl8izSq/OZpchXI7UnLa5Uxu ZccUBJLDXxMQRYOOvufaaA4WoEAMQvt0vN415+ragHYsuvqGHlqF6/BEIagylVM= =2ODY -----END PGP SIGNATURE----- --7IgncvKP0CVPV/ZZ-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/