Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752612AbbBXTkt (ORCPT ); Tue, 24 Feb 2015 14:40:49 -0500 Received: from mout.gmx.net ([212.227.17.21]:58141 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752559AbbBXTkr (ORCPT ); Tue, 24 Feb 2015 14:40:47 -0500 From: Heinrich Schuchardt To: Andrew Morton Cc: Aaron Tomlin , Andy Lutomirski , Davidlohr Bueso , David Rientjes , "David S. Miller" , Fabian Frederick , Guenter Roeck , "H. Peter Anvin" , Ingo Molnar , Jens Axboe , Joe Perches , Johannes Weiner , Kees Cook , Michael Marineau , Oleg Nesterov , "Paul E. McKenney" , Peter Zijlstra , Prarit Bhargava , Rik van Riel , Rusty Russell , Steven Rostedt , Thomas Gleixner , Vladimir Davydov , linux-kernel@vger.kernel.org, Heinrich Schuchardt Subject: [PATCH 2/3 v5] kernel/fork.c: avoid division by zero Date: Tue, 24 Feb 2015 20:38:20 +0100 Message-Id: <1424806701-30099-3-git-send-email-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1424806701-30099-1-git-send-email-xypron.glpk@gmx.de> References: <1424722477-23758-1-git-send-email-xypron.glpk@gmx.de> <1424806701-30099-1-git-send-email-xypron.glpk@gmx.de> X-Provags-ID: V03:K0:CP/vxltZvIh2sgPhyjRk3ZS5pv/LJ4+kNexihjT3uMpuOqCNQ3Z 6lJwwuN6neiJh9/1X6CYri4z484DBpWJrI0b4wY1Tfj9Mkf9CV/BeFn/JG/6m9dfjFyM2+K Sl+sEZUOC7GQOZRAsL2V9CM95NzupfeYdJe8TleMq7zm2R1xuSs2SVG39rz41C4QP3+4HYd xT7eTasN9lP31a8jmt89A== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2461 Lines: 86 PAGE_SIZE is not guaranteed to be equal to or less than 8 times the THREAD_SIZE. E.g. architecture hexagon may have page size 1M and thread size 4096. This would lead to a division by zero in the calculation of max_threads. With 32-bit calculation there is no solution which delivers valid results for all possible combinations of the parameters. The code is only called once. Hence a 64-bit calculation can be used as solution. Signed-off-by: Heinrich Schuchardt --- kernel/fork.c | 38 +++++++++++++++++++++++++++----------- 1 file changed, 27 insertions(+), 11 deletions(-) diff --git a/kernel/fork.c b/kernel/fork.c index 460b044..880c78d 100644 --- a/kernel/fork.c +++ b/kernel/fork.c @@ -88,6 +88,16 @@ #include /* + * Minimum number of threads to boot the kernel + */ +#define MIN_THREADS 20 + +/* + * Maximum number of threads + */ +#define MAX_THREADS FUTEX_TID_MASK + +/* * Protected counters by write_lock_irq(&tasklist_lock) */ unsigned long total_forks; /* Handle normal Linux uptimes. */ @@ -254,23 +264,29 @@ EXPORT_SYMBOL_GPL(__put_task_struct); void __init __weak arch_task_cache_init(void) { } /* - * set_max_threads - * The argument is ignored. + * set_max_threads tries to set the default limit to the suggested value. */ static void set_max_threads(unsigned int max_threads_suggested) { - /* - * The default maximum number of threads is set to a safe - * value: the thread structures can take up at most half - * of memory. - */ - max_threads = totalram_pages / (8 * THREAD_SIZE / PAGE_SIZE); + u64 threads; /* - * we need to allow at least 20 threads to boot a system + * The number of threads shall be limited such that the thread + * structures may only consume a small part of the available memory. */ - if (max_threads < 20) - max_threads = 20; + threads = div64_u64((u64) totalram_pages * (u64) PAGE_SIZE, + (u64) THREAD_SIZE * 8UL); + + if (threads > max_threads_suggested) + threads = max_threads_suggested; + + if (threads > MAX_THREADS) + threads = MAX_THREADS; + + if (threads < MIN_THREADS) + threads = MIN_THREADS; + + max_threads = (int) threads; } void __init fork_init(void) -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/